Repository navigation
fix(linux): Match extra memory exclusion to the captured stack - #173
Merged
Merged
Conversation
`CaptureMemoryDelegateLinux` excludes the full stack even when `max_stack_capture_size` truncates the snapshot. With indirect memory gathering enabled, referenced memory in the discarded portion is omitted. Pass a `ProcessReaderLinux::Thread` copy with `stack_region_size` set to the captured size so the exclusion matches the snapshot. This preserves the reader's thread metadata and captures extra memory within its budget. Original change: #172 Reported by Cursor Bugbot while reviewing `44144ca6` in PR #1: #1 (comment)
mujacica
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to:
CaptureMemoryDelegateLinuxexcludes the full stack even whenmax_stack_capture_sizetruncates the snapshot. With indirect memory gathering enabled, referenced memory in the discarded portion is omitted as brought up at:Pass a
ProcessReaderLinux::Threadcopy withstack_region_sizeset to the captured size so the exclusion matches the snapshot. This preserves the reader's thread metadata and captures extra memory within its budget.