Skip to content

Guard against missing payments in the refund tool #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

Guard against missing payments in the refund tool #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions apps/storefront/lib/ai/tools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,12 @@ export function createTools(customerId: string, _conversationId?: string) {
}

const payment = await db.selectPayment(orderId);
if (!payment) {
return {
refunded: false as const,
reason: `No payment record found for order ${orderId}`,
};
}
const refund = await issueRefund({
chargeId: payment.chargeId,
amount: order.total.amount,
Expand Down
4 changes: 2 additions & 2 deletions apps/storefront/lib/db/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,14 +196,14 @@ export async function selectOrder(
}

// Orders placed before the payments launch have no payment row.
export async function selectPayment(orderId: string): Promise<Payment> {
export async function selectPayment(orderId: string): Promise<Payment | undefined> {
const [row] = await db
.select()
.from(payments)
.where(eq(payments.orderId, orderId))
.limit(1);

return row as Payment;
return row;
}

export async function selectOrders(
Expand Down
Loading