ref(spans): Run process-segments as a task - #4488
Merged
Merged
Conversation
Segments are already processed by the `process_segment` task in production. Set `spans.buffer.process-segments-task-rollout-rate` to 1.0 and drop the dedicated `process-segments` Kafka consumer. The option is set here rather than relying on the default in sentry because self-hosted and sentry are released on different cadences, so a default change in sentry would not take effect until the next release. ref STREAM-1568
untitaker
marked this pull request as ready for review
August 25, 2026 08:41
evanh
approved these changes
Aug 25, 2026
untitaker
added a commit
to getsentry/sentry
that referenced
this pull request
Aug 25, 2026
Segments are already processed by the `process_segment` task in production. This flips the default of `spans.buffer.process-segments-task-rollout-rate` to 1.0 and drops the dedicated `process-segments` Kafka consumer from devservices and the devserver, so devenv matches production. The flusher spawns the task directly, so no raw-mode taskbroker topic is involved. Self-hosted counterpart: getsentry/self-hosted#4488 ref STREAM-1568
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Segments are already processed by the
process_segmenttask in production.This sets
spans.buffer.process-segments-task-rollout-rateto 1.0 and drops thededicated
process-segmentsKafka consumer.The option is set here rather than relying on the default in sentry because
self-hosted and sentry are released on different cadences, so a default change
in sentry would not take effect until the next release.
Sentry counterpart: getsentry/sentry#122555
ref STREAM-1568