Repository navigation
docs: Add trailing slashes to internal links in develop-docs - #19813
Conversation
develop-docs renders at develop.sentry.dev from the same Next config, so the same rule applies there: a link without a trailing slash is served a 308 before the page loads. https://develop.sentry.dev/backend/application-domains -> 308 https://develop.sentry.dev/backend/application-domains/ -> 200 This was the last bucket left from the trailing-slash work in #19639 and #19675, which covered only the user docs. 240 links across 39 files, produced by `pnpm lint:trailing-slash:fix` from #19666. Verified: every changed file differs from master only by added "/" characters, with no slash removed and no external URL altered. A sample of 25 rewritten destinations all return 200 on develop.sentry.dev. `pnpm lint:trailing-slash` is now clean for develop-docs. The 23 remaining violations it reports are drift in docs/, fixed in #19811. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Internal docs links now include a trailing slash. Clicks should skip the extra redirect hop. The plan checks destination page views, RSC fetch failures, client errors, and 5xx responses. An issue escalates when RSC fetch failures or client errors rise, or destination page views fall. Services: PlanWhat changedInternal hrefs in develop-docs MDX now end with a trailing slash. Clicks that previously took a 308 now request the canonical URL first. The change is live after a RiskA wrong slash can send a click to a missing page. Soft navigation then fails the RSC fetch and falls back to a full load. The blast radius is in-app clicks from the edited pages. Highest traffic edited pages are the self-hosted index and the getting-started index. Bookmark requests without a slash still take a 308 and stay out of scope. Intended effectThe new behavior is a first-hop load of the canonical trailing-slash URL. Sentry recorded zero Window:
Do not treat a steady destination count as proof the 308 hop is gone. Regression watchA bad href fails in-app navigation first. Watch RSC fetch errors, client exceptions, and 5xx on the catch-all page route. Resource-script 404s on hashed Window:
Known noise in the error total includes 26 Not observableEdge 308 counts are not in Sentry. Traces for |
The only failure on this PR's external-link check is two links to github.com/getsentry/security-as-code, which is private: lychee gets a 404 anonymously and can never authenticate into it. Both links are pre-existing on master and untouched by this PR, which changes only trailing slashes on internal links. They surfaced here because the checker scans changed files, and this PR touches the file that holds them. .lycheeignore already has a "Private GitHub repos" section listing getsentry, sentry-options-automator, etl and sdk-skills; this belongs alongside them. Verified: lychee reports 0 errors on that file afterwards. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
## DESCRIBE YOUR PR The last bucket from the trailing-slash work in #19639 and #19675, which covered only the user docs. `develop-docs/` renders at **develop.sentry.dev** from the same Next config, so the same rule applies — a link without a trailing slash is served a 308 before the page loads: ``` https://develop.sentry.dev/backend/application-domains -> 308 https://develop.sentry.dev/backend/application-domains/ -> 200 ``` **240 links across 39 files**, produced by `pnpm lint:trailing-slash:fix` from #19666. No hand edits. ### Verification - Every changed file differs from master **only by added `/` characters** — no slash removed, no external URL altered, no other content touched - A sample of 25 rewritten destinations all return **200** on develop.sentry.dev - `pnpm lint:trailing-slash` is now clean for `develop-docs/` The 23 violations the linter still reports are drift in `docs/`, fixed separately in #19811. > Note: `AGENTS.md` describes `develop-docs/` as a submodule, but it isn't one — `git submodule status` is empty and the directory has direct commits in this repo. Worth correcting in that file at some point, though I've left it out of this PR. ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. Select exactly one option. For deadlines, replace `YYYY-MM-DD` with the due date. You can update this information later by editing the PR description. - [ ] Urgent deadline (GA date, etc.): YYYY-MM-DD - [ ] Other deadline: YYYY-MM-DD - [x] No deadline: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've supplied a deadline. Thanks in advance for your help! ## PRE-MERGE CHECKLIST _Make sure you've checked the following before merging your changes:_ - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
DESCRIBE YOUR PR
The last bucket from the trailing-slash work in #19639 and #19675, which covered only the user docs.
develop-docs/renders at develop.sentry.dev from the same Next config, so the same rule applies — a link without a trailing slash is served a 308 before the page loads:240 links across 39 files, produced by
pnpm lint:trailing-slash:fixfrom #19666. No hand edits.Verification
/characters — no slash removed, no external URL altered, no other content touchedpnpm lint:trailing-slashis now clean fordevelop-docs/The 23 violations the linter still reports are drift in
docs/, fixed separately in #19811.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace
YYYY-MM-DDwith the due date. You can update this information later by editing the PR description.SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
🤖 Generated with Claude Code