Skip to content

chore: Remove integration-specific Python middleware ops - #19899

Merged
alexander-alderman-webb merged 1 commit into
masterfrom
webb/middleware-ops
Oct 13, 2026
Merged

alexander-alderman-webb merged 1 commit into
masterfrom
webb/middleware-ops

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

DESCRIBE YOUR PR

Related to getsentry/sentry-conventions#694

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace YYYY-MM-DD with the due date. You can update this information later by editing the PR description.

  • Urgent deadline (GA date, etc.): YYYY-MM-DD
  • Other deadline: YYYY-MM-DD
  • No deadline: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've supplied a deadline.

Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel

vercel Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
develop-docs Ready Ready Preview Oct 12, 2026 6:55am UTC
1 Skipped Deployment
Project Deployment Actions Updated
sentry-docs Ignored Ignored Oct 12, 2026 6:55am UTC

Request Review

@github-actions github-actions Bot added sdk-develop-docs PRs touching develop-docs/sdk Priority: Needs Triage The PR description is missing valid priority information labels Oct 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Please update the IS YOUR CHANGE URGENT? section of the PR description:

  • Select exactly one option.
  • If you selected an urgent or other deadline, provide the date as YYYY-MM-DD.

This information helps the Docs team prioritize your review.

@cursor

cursor Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

The change drops two rows from a span-operations table. The plan checks client errors, page-load latency, and SDK section page loads. An issue escalates when client errors rise or SDK pages stop loading.

Rollout complete

Services: develop-docs.

Plan

What changed

The span-operations article no longer lists middleware.starlette or middleware.django. develop-docs must deploy before this change is live. The develop-docs path and the Vercel production mapping confirm that service.

Risk

A broken markdown table can fail the static site build. A compile error blocks the whole developer-docs deploy. If a bad page ships, readers of that article see a broken table. Reach is low. That article had 11 page loads in seven days. Other SDK telemetry articles on the same site share the page renderer.

Intended effect

This is a documentation edit. Telemetry does not show whether those two operations left the published table. Record intended_effect: unknown unless a content review of the live article shows the rows are gone. Absent looks like middleware.starlette or middleware.django still in that table. The article still loaded 11 times in seven days. That count only shows the URL is reachable. It does not show the new table text.

Regression watch

A bad MDX render on this path can throw client errors on every developer-docs page. All pageloads share transaction /:path*?. Watch that transaction. Also watch SDK section page loads. Those loads would fall if the SDK tree failed to render.

Signal Baseline Window Rule Source
Client error rate on transaction /:path*? versus pageload count 4.0-4.1% (16 errors / 390 pageloads in 24h; 203 errors / 5070 pageloads in 7d). TypeError 8 and Error 5 in 24h. 2026-10-11T06:53:00Z to 2026-10-12T06:53:00Z and 2026-10-05T06:53:00Z to 2026-10-12T06:53:00Z Hold in 4.0-4.1%. Escalate if the rate rises above 5% or TypeError jumps above 8 per 24h. sentry/develop-docs errors transaction:"/:path*?" environment:production count(); spans span.op:pageload transaction:"/:path*?" environment:production count()
Pageload p95 on transaction /:path*? 7.3-8.6s (24h p95 7262ms; 7d p95 8603ms). p75 3.6-4.0s. 2026-10-11T06:53:00Z to 2026-10-12T06:53:00Z and 2026-10-05T06:53:00Z to 2026-10-12T06:53:00Z Hold p95 in 7.3-8.6s. Escalate if p95 rises above 8.6s. sentry/develop-docs spans span.op:pageload transaction:"/:path*?" environment:production p95(span.duration)
SDK share of docs.page.load 15.5-16.3% (125 / 804 in 24h; 1651 / 10149 in 7d). 2026-10-11T06:53:00Z to 2026-10-12T06:53:00Z and 2026-10-05T06:53:00Z to 2026-10-12T06:53:00Z Hold in 15.5-16.3%. Escalate if the share falls below 12%. sentry/develop-docs metrics docs.page.load with page_type:sdk and unfiltered sum

Sunday traffic in the 24h window was lower than the seven-day mean. Prefer the ratios. Raw counts will rise on a weekday deploy.

Not observable

The published table text is not in telemetry. Per-URL pageload traces are not available because every page uses transaction /:path*?. docs.page.not_found returned null. LCP has no page_type split for SDK articles.

@alexander-alderman-webb alexander-alderman-webb changed the title chore: Remove deprecated integration-specific Python middleware ops chore: Remove integration-specific Python middleware ops Oct 13, 2026
@alexander-alderman-webb
alexander-alderman-webb merged commit d9d5dda into master Oct 13, 2026
30 of 31 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/middleware-ops branch October 13, 2026 09:53
@cursor

cursor Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Verified in production

  • The live article dropped the two middleware rows and the docs site stayed healthy.

This branch was successfully deployed

1 active deployment
Preview – develop-docs — 2c358edd Deployed Oct 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Needs Triage The PR description is missing valid priority information sdk-develop-docs PRs touching develop-docs/sdk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants