Skip to content

ref(develop): Define client report quantity instead of discarded envelope section - #19966

Open
sentry-junior[bot] wants to merge 5 commits into
masterfrom
dsz/ref-client-report-quantity-definition
Open

sentry-junior[bot] wants to merge 5 commits into
masterfrom
dsz/ref-client-report-quantity-definition

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

DESCRIBE YOUR PR

#19854 added a "Quantity of Discarded Envelopes" section under Network Failure Recording to make clear that batched logs, metrics, and spans count their contained items, not 1 per envelope item. The rule is right, but the section makes it harder to follow:

  • The rule isn't specific to network failures. It applies to every discard reason.
  • Its bullets restate MUSTs that the log byte, metric byte, and span outcome sections already define.
  • "record a client report entry for every telemetry item" reads as one entry per item, which conflicts with the (reason, category) → quantity aggregation map.

This PR replaces the section with a short Quantity definition under Concepts, and the quantity field in the payload table now links to it. The definition says quantity counts telemetry items, not envelopes or envelope items; each entry in a container item's items array counts as one; and byte categories use bytes. The links from the logs, metrics, and spans specs now point to the new definition. Spec version is bumped to 1.26.0.

cc @szokeasaurusrex

IS YOUR CHANGE URGENT?

  • Urgent deadline (GA date, etc.): YYYY-MM-DD
  • Other deadline: YYYY-MM-DD
  • No deadline: Not urgent, can wait up to 1 week+

via @szokeasaurusrex.

--

View Junior Session [Sentry]

…lope section

Co-Authored-By: Daniel SzokeNSTEIN <7881302+szokeasaurusrex@users.noreply.github.com>
@vercel

vercel Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
develop-docs Ready Ready Preview Oct 14, 2026 9:06am UTC
1 Skipped Deployment
Project Deployment Actions Updated
sentry-docs Ignored Ignored Preview Oct 14, 2026 9:06am UTC

Request Review

@github-actions github-actions Bot added sdk-develop-docs PRs touching develop-docs/sdk Priority: Normal Docs review has no urgent deadline labels Oct 14, 2026
Comment thread develop-docs/sdk/telemetry/client-reports.mdx Outdated
sentry-junior Bot and others added 3 commits October 14, 2026 08:57
Co-Authored-By: Daniel SzokeNSTEIN <7881302+szokeasaurusrex@users.noreply.github.com>
Co-Authored-By: Daniel SzokeNSTEIN <7881302+szokeasaurusrex@users.noreply.github.com>
Comment thread develop-docs/sdk/telemetry/client-reports.mdx Outdated
@cursor

cursor Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Rollouts skipped this pull request: The pull request is documentation-only changes (MDX and spec docs) in an application repo, matching the criterion to skip Markdown that does not ship to a depl…

Mention @change-monitor in a comment to monitor it anyway.

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

This branch was successfully deployed

1 active deployment
Preview – develop-docs — 80114e3f Deployed Oct 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Normal Docs review has no urgent deadline sdk-develop-docs PRs touching develop-docs/sdk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants