Repository navigation
ref(develop): Define client report quantity instead of discarded envelope section - #19966
Open
sentry-junior[bot] wants to merge 5 commits into
Open
sentry-junior[bot] wants to merge 5 commits into
sentry-junior[bot] wants to merge 5 commits into
Conversation
…lope section Co-Authored-By: Daniel SzokeNSTEIN <7881302+szokeasaurusrex@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Co-Authored-By: Daniel SzokeNSTEIN <7881302+szokeasaurusrex@users.noreply.github.com>
Co-Authored-By: Daniel SzokeNSTEIN <7881302+szokeasaurusrex@users.noreply.github.com>
szokeasaurusrex
marked this pull request as ready for review
October 14, 2026 10:03
Contributor
|
Rollouts skipped this pull request: The pull request is documentation-only changes (MDX and spec docs) in an application repo, matching the criterion to skip Markdown that does not ship to a depl… Mention |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
#19854 added a "Quantity of Discarded Envelopes" section under Network Failure Recording to make clear that batched logs, metrics, and spans count their contained items, not 1 per envelope item. The rule is right, but the section makes it harder to follow:
(reason, category) → quantityaggregation map.This PR replaces the section with a short Quantity definition under Concepts, and the
quantityfield in the payload table now links to it. The definition says quantity counts telemetry items, not envelopes or envelope items; each entry in a container item'sitemsarray counts as one; and byte categories use bytes. The links from the logs, metrics, and spans specs now point to the new definition. Spec version is bumped to 1.26.0.cc @szokeasaurusrex
IS YOUR CHANGE URGENT?
via @szokeasaurusrex.
--
View Junior Session [Sentry]