Repository navigation
docs(sdk): Clarify strict mode for callback error isolation - #19967
Open
sentry-junior[bot] wants to merge 2 commits into
Open
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Alexander Dinauer <alexander.dinauer@sentry.io>
Co-Authored-By: Alexander Dinauer <alexander.dinauer@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
github-actions
Bot
added
sdk-develop-docs
Contributor
|
Rollouts skipped this pull request: Documentation-only change in an application repo (Markdown/MDX files that do not ship to a deployed site). Mention |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Rewords the strict mode paragraph in the hooks spec's callback error isolation section.
The old wording said SDKs MUST NOT pass the event reporting a propagated callback error through the callback that failed. That reads as if SDKs have to remember which callback failed and skip it for the follow-up event, for example the one an uncaught exception handler creates. That adds complexity and is risky, since skipping
before_sendcould send data it was meant to strip. The intent was to avoid reporting loops.The paragraph now says that directly: in strict mode the callback failure propagates, and SDKs MUST prevent error loops caused by a failing callback and an uncaught exception handler. Also bumps the spec to 1.1.1 with a changelog entry.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace
YYYY-MM-DDwith the due date. You can update this information later by editing the PR description.PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
via alexander.dinauer.
--
View Junior Session [Sentry]