Repository navigation
docs(sdk): Migrate GraphQL spec to Writing SDK Specs guidelines - #20086
Closed
sentry-junior[bot] wants to merge 1 commit into
Closed
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Co-Authored-By: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
sentry-junior
Bot
force-pushed
the
junior/migrate-graphql-spec
branch
from
October 19, 2026 16:12
128febf to
9216537
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Migrates the GraphQL spec to the Writing SDK Specs guidelines, using the
writing-sdk-specsskill. It's stacked on the Feature Flags migration (#20085).What changed in the spec:
request.api_target: "graphql", because Relay only scrubs GraphQL variables when it is set; not attaching request or response bodies, orgraphql.document, unless the user's data collection settings allow it; and not stopping the app from reading a body the SDK reads.fingerprint, notfingerprints, and it holds real values (["GetUser", "query", "200"]) instead of literal$operationNameplaceholders. This matches what Java Apollo and .NET send.request.dataandcontexts.response.datashould be JSON objects, because that is what Relay scrubs.typeandcategoryvalues, plus the resolver and data loader breadcrumb fields, moved to Implementation Guidance as the pattern Java and .NET use. They are not needed for interop, and Python and JavaScript use different values.spec_guidelines: writing-specs@0.1, and lists HTTP Client inspec_depends_on.Because existing requirements changed, this is a major bump to 2.0.0, and every section's
sinceis 2.0.0. Existing section anchors are unchanged. Two sections are new:graphql-http-client, which keeps the old "follow HTTP Client" overview as a requirement, andgraphql-event-data, which holds the request and response data rules shared by clients and servers. SDK owners (Java, .NET, Python, JavaScript) should confirm the new requirement levels before this leaves draft.IS YOUR CHANGE URGENT?
PRE-MERGE CHECKLIST
via @szokeasaurusrex.
--
View Junior Session [Sentry]