Repository navigation
docs(sdk): Migrate Modules spec to Writing SDK Specs guidelines - #20089
Draft
sentry-junior[bot] wants to merge 8 commits into
Draft
sentry-junior[bot] wants to merge 8 commits into
sentry-junior[bot] wants to merge 8 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
github-actions
Bot
added
sdk-develop-docs
Repo-local skill that points agents at the Writing SDK Specs page, has them check their own changes against it, and report pre-existing violations without fixing them. Listed in AGENTS.md and SKILL.md. Co-Authored-By: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
Move the skill from .claude/skills/ to .agents/skills/ and declare it in agents.toml with a path: source, matching the dotagents convention for repo-local skills. Keep a .claude/skills symlink like the existing ones. Co-Authored-By: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
The root SKILL.md is a routing guide, not how skills are discovered. AGENTS.md already lists the skill. Co-Authored-By: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
Co-Authored-By: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
Co-Authored-By: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
sentry-junior
Bot
force-pushed
the
junior/writing-sdk-specs-skill
branch
from
October 19, 2026 17:05
8a84e4d to
7020ce6
Compare
Co-Authored-By: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
Co-Authored-By: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
Co-Authored-By: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
sentry-junior
Bot
force-pushed
the
junior/migrate-modules-spec
branch
from
October 19, 2026 17:10
e875615 to
c183f09
Compare
sentry-junior
Bot
force-pushed
the
junior/writing-sdk-specs-skill
branch
from
October 20, 2026 08:40
538818e to
7d3591a
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Migrates the Modules spec to the Writing SDK Specs guidelines (#20081), using the
writing-sdk-specsskill. Stacked on #20083.Requirement changes, for review:
processEventlifecycle hook". It's an implementation detail. The observable result (modules on events) is still required.modulesfield SHOULD list every module installed in the application's environment or loaded by the application, each with the version the application uses. The discovery strategies and the precedence tip moved to Implementation Guidance.processEventandevent.modulesrequirements) to "SHOULD". The format (a map from module name to version string in themodulesfield) stays "MUST", since that's what Sentry reads.The page now has a Scope section (it applies to SDKs that implement the Modules integration) and defines "module", following the Structure and Clarity rules. The JSON snippet and the Node.js/Python
initexamples were removed because they only restated requirements. The page declaresspec_guidelines: writing-specs@0.1. Since existing requirements changed, this is a major bump to 2.0.0, and every section'ssinceis 2.0.0, matching #20085.SDK owners should confirm the "MUST" → "SHOULD" change and the narrowed "MAY" before this leaves draft.
IS YOUR CHANGE URGENT?
PRE-MERGE CHECKLIST
via @szokeasaurusrex.
--
View Junior Session [Sentry]