Skip to content

chore: pin floating NuGet package versions - #5522

Open
jamescrosswell wants to merge 1 commit into
mainfrom
chore/pin-floating-package-versions
Open

chore: pin floating NuGet package versions#5522
jamescrosswell wants to merge 1 commit into
mainfrom
chore/pin-floating-package-versions

Conversation

@jamescrosswell

@jamescrosswell jamescrosswell commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

Closes #5276

Rather than introducing packages.lock.json, we've pinned the only two non-specific NuGet version declarations in the repo so the dependency graph is explicit. Both are pinned to the versions they already resolved to, verified by comparing project.assets.json before and after — restore output is unchanged.

Newtonsoft.Json used a `13.*` wildcard and FluentAssertions a
`[7.2.2,8.0.0)` range. Both are now pinned to the versions they already
resolved to (13.0.4 and 7.2.2 respectively), so the dependency graph is
explicit without changing what gets restored.

The FluentAssertions range also acted as a guard against Dependabot
bumping into the license-changed 8.x, so that guard moves to an explicit
`ignore` entry for semver-major updates in dependabot.yml.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.72%. Comparing base (eaffc07) to head (69625ac).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5522   +/-   ##
=======================================
  Coverage   74.72%   74.72%           
=======================================
  Files         513      513           
  Lines       18826    18826           
  Branches     3680     3680           
=======================================
+ Hits        14067    14068    +1     
+ Misses       3879     3878    -1     
  Partials      880      880           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jamescrosswell
jamescrosswell marked this pull request as ready for review August 31, 2026 04:09
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(dotnet): use NuGet lock file (packages.lock.json)

1 participant