Skip to content

test: remove stale net6.0/net7.0 verified snapshots - #5531

Open
jamescrosswell wants to merge 1 commit into
mainfrom
chore/remove-stale-tfm-snapshots
Open

test: remove stale net6.0/net7.0 verified snapshots#5531
jamescrosswell wants to merge 1 commit into
mainfrom
chore/remove-stale-tfm-snapshots

Conversation

@jamescrosswell

@jamescrosswell jamescrosswell commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

Deletes six dead Verify snapshots for net6.0/net7.0:

test/Sentry.Tests/SentryOptionsTests.Integrations_default_ones_are_properly_registered.DotNet6_0.DotNet.verified.txt
test/Sentry.Tests/SentryOptionsTests.Integrations_default_ones_are_properly_registered.DotNet6_0.OSX.DotNet.verified.txt
test/Sentry.Tests/SentryOptionsTests.Integrations_default_ones_are_properly_registered.DotNet6_0.Windows.DotNet.verified.txt
test/Sentry.Tests/SentryOptionsTests.Integrations_default_ones_are_properly_registered.DotNet7_0.DotNet.verified.txt
test/Sentry.Tests/SentryOptionsTests.Integrations_default_ones_are_properly_registered.DotNet7_0.OSX.DotNet.verified.txt
test/Sentry.Tests/SentryOptionsTests.Integrations_default_ones_are_properly_registered.DotNet7_0.Windows.DotNet.verified.txt

The test uses .UniqueForTargetFrameworkAndVersion(), so Verify only ever resolves a snapshot whose suffix matches a TFM currently being built. net6.0/net7.0 were dropped in #3807, which left these behind; nothing has been able to select them since.

Closes #5530

#skip-changelog

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@jamescrosswell
jamescrosswell marked this pull request as ready for review September 2, 2026 00:03
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.66%. Comparing base (b96ff3b) to head (8d2ed9e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5531      +/-   ##
==========================================
- Coverage   74.67%   74.66%   -0.02%     
==========================================
  Files         515      515              
  Lines       18909    18909              
  Branches     3691     3691              
==========================================
- Hits        14120    14118       -2     
- Misses       3904     3906       +2     
  Partials      885      885              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove stale net6.0/net7.0 verified snapshots left behind when those TFMs were dropped

1 participant