Skip to content

Fix JDK 21 findings in the JVM integrations - #6259

Merged
markushi merged 1 commit into
build/jdk-21from
fix/jdk21-integrations
Oct 20, 2026
Merged

markushi merged 1 commit into
build/jdk-21from
fix/jdk21-integrations

Conversation

@markushi

Copy link
Copy Markdown
Member

Part of the JDK 21 toolchain move (#6242). The newer javac, Error Prone and NullAway report findings that fail the build, so the affected modules need to be made compliant before the base PR can go green.

Split per module group to keep each review small. Base PR: #6242.

🤖 Generated with Claude Code

@markushi
markushi force-pushed the fix/jdk21-integrations branch 2 times, most recently from 3bb855b to aa0a619 Compare October 16, 2026 07:07
@markushi
markushi marked this pull request as ready for review October 16, 2026 07:12
@markushi
markushi force-pushed the fix/jdk21-integrations branch from aa0a619 to 9f7c0b9 Compare October 16, 2026 07:27
@markushi
markushi merged commit 0f3f8bc into build/jdk-21 Oct 20, 2026
16 of 59 checks passed
@markushi
markushi deleted the fix/jdk21-integrations branch October 20, 2026 14:42
markushi added a commit that referenced this pull request Oct 21, 2026
… Error Prone (#6242)

* build: Switch to JDK 21 and upgrade Mockito, Robolectric and Error Prone

* build: Compile tests for JDK 21 and fix buildSrc JVM target

* build: Compile with a JDK 21 toolchain from a build-logic convention plugin

* docs(kafka): Explain the explicit double cast at the latency call site

* build: Compile the samples and their tests with the toolchain JDK

* Format code

* build: Drop the now-unused JvmTarget imports from the samples

* build: Clarify the jvm-targets plugin comments and rename its helper

* build: Require JDK 21 to run Gradle again

* build: Keep the Spring Boot 2 sample apps on their published bytecode level

* ci: Drop the stale Java version from the build job name

* build: Keep Robolectric at 4.15 and leave its test environment untouched

* build: Move the Java 8 release pin into the jvm-targets convention plugin

* build: Drop the Error Prone and NullAway code fixes, they move to their own PR

* ci: Drop the stale Java version from the build job name

* fix(core): Suppress the new Error Prone and javac 21 findings in the sentry module

* fix(core): Resolve the remaining Error Prone and javac 21 findings in the sentry module

* build: Move the JDK and bytecode level decisions into the io.sentry.compilation plugin

* Address PR comments

* test(android): Make the flush timeout verifies match the real log call

* chore(core): Reword the JDK 21 suppression comments

* build: Keep only the javac unit test targets inside afterEvaluate

* build: Drop afterEvaluate, pin the Kotlin API level and rename the convention plugin

* Fix JDK 21 findings in sentry-android-core (#6261)

Fix JDK 21 findings in sentry-android-core

* Fix JDK 21 findings in the Spring modules (#6260)

* Fix JDK 21 findings in the JVM integrations (#6259)

* fix multiplatform target compilations

---------

Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants