Repository navigation
build: Resolve build-logic and buildSrc plugins from Maven Central first - #6270
Merged
Merged
Conversation
Co-Authored-By: Nelson Osacky <nelson.osacky@sentry.io>
Co-Authored-By: Nelson Osacky <nelson.osacky@sentry.io>
runningcode
marked this pull request as ready for review
October 15, 2026 13:42
runningcode
requested review from
0xadam-brown,
adinauer,
markushi,
romtsn and
runningcode
as code owners
October 15, 2026 13:42
📲 Install BuildsAndroid
|
runningcode
enabled auto-merge (squash)
October 15, 2026 13:49
0xadam-brown
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
In both
build-logicandbuildSrc:pluginManagementblock tosettings.gradle.ktsthat listsmavenCentral()beforegradlePluginPortal().build.gradle.ktsintodependencyResolutionManagementinsettings.gradle.ktsand setsRepositoriesMode.FAIL_ON_PROJECT_REPOS, so the repositories are declared in one place and project-level repos can't creep back in.build-logicnow resolves dependencies frommavenCentral()first, thengradlePluginPortal(). Before, it used the portal only.buildSrckeepsmavenCentral()only, as before.💡 Motivation and Context
The SDK Size Analysis job started failing on
mainand PRs while configuring:build-logic:These included builds had no
pluginManagementrepos, so thekotlin-dslplugin classpath resolved only through the Gradle Plugin Portal. The portal just redirects these artifacts to Maven Central, so going to Central directly takes the portal out of the path for anything that isn't a portal-only plugin.💚 How did you test it?
Not run locally. CI on this PR is the check, especially the SDK Size Analysis job.
📝 Checklist
#skip-changelog
via no.
--
View Junior Session [Sentry]