Repository navigation
feat(sample): [Nav3 Lifecycle 5] Add Nav3 lifecycle scenarios to sample app - #6309
0xadam-brown wants to merge 1 commit into
Conversation
|
📲 Install BuildsAndroid
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7039fb1. Configure here.
| transaction?.setTag(NAVIGATION_SAMPLE_ACTIVITY_TAG, activityName) | ||
| transaction?.setTag(NAVIGATION_SAMPLE_SESSION_TAG, sessionId) | ||
| } | ||
| } |
There was a problem hiding this comment.
History filter misses scenario tag
Medium Severity
tagCurrentNav3Scenario writes sample_nav3_scenario only onto Sentry.getSpan(), while activity and session tags are also applied on the scope transaction. History recording now drops any finished transaction missing sample_nav3_scenario. If the current span is a child, or the destination SideEffect runs before the navigation transaction exists, the sheet silently omits that transaction.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 7039fb1. Configure here.
Add runnable multi-Activity and multi-Fragment Navigation 3 scenarios with shared transaction history so lifecycle handoffs can be exercised in the Android sample.\n\nRefs JAVA-274
7039fb1 to
8530b8d
Compare
f24236a to
810739e
Compare


PR Stack (Nav3 Lifecycle)
📜 Description
Add runnable Navigation 3 sample flows for applications with multiple Activities and multiple Fragments, each hosting its own
SentryNavEffect.The sample records a shared navigation transaction history, labels transactions by Activity, and provides scenarios for Activity handoffs, Fragment replacement, dialogs, and ViewPager pages.
💡 Motivation and Context
These scenarios make the lifecycle behavior introduced by the stack directly observable and provide a practical harness for manual verification and future debugging.
addresses: JAVA-785
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Merge the stack from Part 1 through Part 5 using merge commits, then squash-merge the collection PR into
main.#skip-changelog