Repository navigation
Conversation
📲 Install BuildsAndroid
|
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Comment on lines
+1
to
+17
| /* | ||
| * Adapted from https://github.com/androidx/androidx/blob/c799cba927a71f01ea6b421a8f83c181682633fb/buildSrc/private/src/main/kotlin/androidx/build/MavenUploadHelper.kt#L524-L549 | ||
| * | ||
| * Copyright 2018 The Android Open Source Project | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
There was a problem hiding this comment.
build-logic/src/main/kotlin/io/sentry/gradle/AarTypes.kt — This file is adapted from AndroidX MavenUploadHelper (Apache 2.0, Copyright 2018 The Android Open Source Project) and has a complete attribution header, but there is no matching entry in THIRD_PARTY_NOTICES.md. Add an entry with Source URL, License name, Copyright, Scope, and full license text.
Evidence
- File header lines 1–17 state Adapted from androidx MavenUploadHelper, Copyright 2018 The Android Open Source Project, and Apache License 2.0 with source URL.
- Grep of THIRD_PARTY_NOTICES.md for AarTypes, MavenUploadHelper, and the androidx MavenUploadHelper path returns no matching entry.
- Existing AOSP NOTICES entries cover Base64, Thread Dump Parsing, and Jetpack Compose UI only — not this Maven POM aar-type helper.
- assignAarTypes() is live code called from SentryPublishPlugin.kt.
Identified by Warden · check-code-attribution · JAJ-FF6
runningcode
reviewed
Oct 22, 2026
| } | ||
| } | ||
|
|
||
| subprojects { |
Contributor
There was a problem hiding this comment.
im crying right now because this is so beautiful
Contributor
|
there's a IP compatible way to apply a plugin to all subprojects. see this doc: https://docs.gradle.org/current/userguide/isolated_projects.html#sec:applying_plugins_from_a_lifecycle_callback |
Resolve plugins {} conflict in sentry-samples-spring-boot-4/build.gradle.kts:
keep io.sentry.spotless and io.sentry.jdk-target from this branch, drop
io.sentry.systemtest as removed on main (#6298).
Resolve spring sample plugin conflict after main removed io.sentry.systemtest; retain convention plugins added by this branch.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Removes the root
subprojects {}block: Spotless, the JDK target, Detekt and the publishing setup are now applied per module via convention plugins inbuild-logic(io.sentry.detekt,io.sentry.publish,io.sentry.publish.multiplatform). As a side effect the four integration-test modules and the empty container projects stop publishing and building distributions, which they only ever did because the old exclusion test matched onproject.namerather than the path.💡 Motivation and Context
First step towards Isolated Projects, which forbids cross-project configuration.
💚 How did you test it?
Built the distribution zips for 12 modules covering each archetype (plain JVM, Spring, BOM, Android library, umbrella, KMP, shadow agent) before and after, and compared zip contents, POMs and Gradle module metadata. The only difference is a byte-identical duplicate
sources.jarentry disappearing fromsourcesElementsin the plain-JVM modules.spotlessCheck,apiCheck(no.apifile changed),detektand unit tests pass.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Follow-up PRs for the remaining cross-project access:
allprojects {},buildForCodeQL,apiValidation.ignoredProjects, thesubprojects {}inio.sentry.javadoc.aggregate, andsentry-bom'sevaluationDependsOnwalk.#skip-changelog