Skip to content

sample(android): Split Nav3 fragment scenarios into separate tabs in the Nav3 sample - #6372

Merged
0xadam-brown merged 1 commit into
mainfrom
ref/nav3-fragment-scenario-tabs
Oct 27, 2026
Merged

sample(android): Split Nav3 fragment scenarios into separate tabs in the Nav3 sample#6372
0xadam-brown merged 1 commit into
mainfrom
ref/nav3-fragment-scenario-tabs

Conversation

@0xadam-brown

@0xadam-brown 0xadam-brown commented Oct 23, 2026

Copy link
Copy Markdown
Member

📜 Description

PR improves our Nav3 sample app by creating separate multi-fragment, fragment overlays, and ViewPager2 tabs, rather than jamming them all into a single tab.

💡 Motivation and Context

The previous UX was confusing; the current one is better.

💚 How did you test it?

Manually.

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

#skip-changelog

@0xadam-brown @codex
ref(android): Split Nav3 fragment scenarios into tabs in the Nav3 sample
1e006b7 
Give fragment replacement, dialog overlays, and ViewPager2 pages separate entry points while preserving their test paths. Remove unused placeholders and place Custom before Performance.

Co-Authored-By: Codex <noreply@openai.com>
@0xadam-brown 0xadam-brown added the ship-it PR is ready to merge from a reviewer perspective label Oct 23, 2026
@0xadam-brown 0xadam-brown changed the title ref(android): Split Nav3 fragment scenarios into separate tabs in the Nav3 sample sample(android): Split Nav3 fragment scenarios into separate tabs in the Nav3 sample Oct 23, 2026
@sentry

sentry Bot commented Oct 23, 2026

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.61.1 (1) release

⚙️ sentry-android Build Distribution Settings

runningcode
runningcode approved these changes Oct 27, 2026
View reviewed changes

@runningcode runningcode left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a very light review since this is sample code! Looks great!

@0xadam-brown
0xadam-brown merged commit 72bcb18 into main Oct 27, 2026
34 of 35 checks passed
@0xadam-brown
0xadam-brown deleted the ref/nav3-fragment-scenario-tabs branch October 27, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@runningcode runningcode runningcode approved these changes
@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner
@romtsn romtsn Awaiting requested review from romtsn
@markushi markushi Awaiting requested review from markushi

Assignees

No one assigned

Labels

ship-it PR is ready to merge from a reviewer perspective

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0xadam-brown @runningcode