feat(frameworks)!: Use function op for framework functions - #23047
Open
msonnb wants to merge 5 commits into
Open
feat(frameworks)!: Use function op for framework functions#23047msonnb wants to merge 5 commits into
function op for framework functions#23047msonnb wants to merge 5 commits into
Conversation
Member
Author
|
c'mon, do something |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0306fef. Configure here.
Contributor
size-limit report 📦
|
msonnb
force-pushed
the
ms/framework-function-op
branch
from
August 5, 2026 09:22
0306fef to
502d908
Compare
msonnb
marked this pull request as ready for review
August 5, 2026 09:47
msonnb
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
August 5, 2026 09:47
nicohrubec
reviewed
Aug 6, 2026
| ); | ||
|
|
||
| expect(actionSpan).toBeDefined(); | ||
| expect(actionSpan?.op).toBe('action.remix'); |
Member
There was a problem hiding this comment.
l: do we (need to) preserve this information somehow that this is action or loader? do we set code.function.name here? if we set it we should probably also assert on it
Member
Author
There was a problem hiding this comment.
yes we set it and implicitly asserted it by using it in the .find() predicate above, but added an explicit assertion and changed to code.function.name since code.function will be deprecated 👍
| const middlewareSpan = transaction?.spans?.find( | ||
| (span: { data?: { 'sentry.op'?: string } }) => span.data?.['sentry.op'] === 'function.react_router.middleware', | ||
| ); | ||
| const middlewareSpan = transaction?.spans?.find(span => span.data?.['code.function.name'] === 'middleware'); |
Member
There was a problem hiding this comment.
l: are these actually middlewares or just functions that are called middleware? if the former shouldn't the op be middleware?
Member
Author
There was a problem hiding this comment.
good catch! updated to middleware
| trace_id: expect.any(String), | ||
| data: { | ||
| 'sentry.origin': 'auto.http.react_router', | ||
| 'sentry.op': 'function.react_router.action', |
Member
There was a problem hiding this comment.
q: same here is action preserved as code.function.name?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Framework function spans previously each carried a granular, per-framework op (
function.sveltekit.load,function.react_router.loader,function.nextjs,function.remix.document_request,function.server_action,function.tanstackstart, …). This unifies them onto the standardizedfunctionop from conventionsThe detail that lived in the op now lives in
sentry.originandcode.function.name(the wrapped function's real name), added where the origin alone no longer distinguishes spans.Affected:
sveltekit,react-router,nextjs,remix,solidstart,tanstackstart-react.part of #22446