fix(browser): Use drift-corrected time origin for INP, replay and profiling - #23067
Draft
Lms24 wants to merge 1 commit into
Conversation
…filing `timestampInSeconds` re-derives its time origin when it detects clock drift, but `browserPerformanceTimeOrigin` caches the origin resolved at SDK init and never revisits it. Consumers that convert a `PerformanceEntry`'s monotonic `startTime` to wall clock time therefore end up on a different timeline than span and event timestamps once a correction has happened. Exposes the corrected origin as `correctedPerformanceTimeOrigin` and uses it for the consumers that outlive a span timeout: INP (reports on pagehide) and replay (sessions run up to an hour). Profiling already compensated for the SDK changing its time origin, but computed the adjustment against the stale cached value. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 25c1b28. Configure here.
| // Since JS self profiling time origin is always initialized to performance.timeOrigin, we need to adjust for | ||
| // the drift between the SDK selected value and our profile time origin. | ||
| const perfOrigin = browserPerformanceTimeOrigin(); | ||
| const perfOrigin = correctedPerformanceTimeOrigin(); |
There was a problem hiding this comment.
Profile elapsed times shift after drift
High Severity
Switching convertJSSelfProfileToSampledFormat to correctedPerformanceTimeOrigin makes adjustForOriginChange non-zero after runtime clock drift. That delta is added into every elapsed_since_start_ns, so the first sample is no longer 0 and all relative sample times shift by the full drift (often negative after device sleep). Continuous profiling absolute timestamps are fine; this only breaks transaction/sampled profiles.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 25c1b28. Configure here.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.