Repository navigation
ci: Fail when a Playwright version drifts from the pinned one - #25383
Merged
Merged
Conversation
mydea
added this pull request to stack #25385
October 15, 2026 07:44
mydea
force-pushed
the
ci/check-playwright-versions
branch
from
October 15, 2026 11:35
959a597 to
e179217
Compare
mydea
removed this pull request from stack #25385
October 15, 2026 11:37
mydea
added this pull request to stack #25392
October 15, 2026 11:37
mydea
force-pushed
the
ci/check-playwright-versions
branch
from
October 15, 2026 11:58
e179217 to
a9f3ac0
Compare
mydea
removed this pull request from stack #25392
October 15, 2026 11:58
mydea
added this pull request to stack #25397
October 15, 2026 11:58
mydea
force-pushed
the
ci/check-playwright-versions
branch
from
October 15, 2026 12:51
a9f3ac0 to
92a55bf
Compare
mydea
removed this pull request from stack #25397
October 15, 2026 12:51
mydea
added this pull request to stack #25401
October 15, 2026 12:52
mydea
removed this pull request from stack #25401
October 15, 2026 12:55
mydea
changed the base branch from
chore/bump-playwright-1.64
to
test/e2e-remove-event-dumps
October 15, 2026 12:55
mydea
added this pull request to stack #25405
October 15, 2026 12:56
mydea
force-pushed
the
ci/check-playwright-versions
branch
from
October 15, 2026 14:28
92a55bf to
f52aeb7
Compare
mydea
force-pushed
the
ci/check-playwright-versions
branch
from
October 16, 2026 07:35
f52aeb7 to
9a87a66
Compare
mydea
force-pushed
the
ci/check-playwright-versions
branch
from
October 16, 2026 08:52
9a87a66 to
1cdd682
Compare
mydea
force-pushed
the
ci/check-playwright-versions
branch
from
October 16, 2026 09:16
1cdd682 to
2280417
Compare
mydea
force-pushed
the
ci/check-playwright-versions
branch
2 times, most recently
from
October 19, 2026 09:06
c78c274 to
f577ac3
Compare
mydea
force-pushed
the
ci/check-playwright-versions
branch
from
October 19, 2026 09:24
f577ac3 to
543416a
Compare
mydea
marked this pull request as ready for review
October 19, 2026 09:33
All packages and E2E apps must declare the exact `@playwright/test` version of `@sentry-internal/test-utils`. The check runs in the Lint job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
force-pushed
the
ci/check-playwright-versions
branch
from
October 19, 2026 15:00
9b0d30b to
2048658
Compare
JPeer264
approved these changes
Oct 19, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
LGTM. Theoretically we could also solve this with a pnpm workspace file and a workspace:*, not sure though if that works nicely with how we copy E2E tests into a temp dir
Member
Author
yeah I think this will not work because the actual pnpm install command will be executed far away from the workspace (by design) 😅 we could enforce strict peer dependencies (because test-utils has a peer dep on this) but this is a bit of a heavier lift because a lot of e2e test apps have issues there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a check that every
package.jsondeclares the same exact@playwright/testversion as@sentry-internal/test-utils. That covers the root,packages/*,dev-packages/*and every E2E app. It runs in the Lint job's parallel group, so a drifting app fails fast instead of silently testing against different browsers.@sentry-internal/test-utilsis the reference because E2E apps already depend on it for their Playwright config. The check is an inlinegit grepover trackedpackage.jsonfiles, so it needs no installed dependencies and picks up new locations without a list to maintain. Only@playwright/testis checked, sinceplaywrightandplaywright-corenever appear without it.Based on #25404, outside the PR stack.
🤖 Generated with Claude Code