Skip to content

fix(v10/cloudflare): auto-instrument a re-exported default export - #25407

Open
sentry-junior[bot] wants to merge 2 commits into
v10from
backport/v10-25345-cloudflare-default-reexport
Open

sentry-junior[bot] wants to merge 2 commits into
v10from
backport/v10-25345-cloudflare-default-reexport

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Backport of: #25345

Differences to the original PR

via Junior system actor junior.

--

View Junior Session [Sentry]

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 28.21 kB added added
@sentry/browser - with treeshaking flags 26.66 kB added added
@sentry/browser (incl. Tracing) 47.23 kB added added
@sentry/browser (incl. Tracing + Span Streaming) 49.03 kB added added
@sentry/browser (incl. Tracing, Profiling) 52.02 kB added added
@sentry/browser (incl. Tracing, Replay) 86.64 kB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 76.27 kB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 91.35 kB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 103.97 kB added added
@sentry/browser (incl. Feedback) 45.38 kB added added
@sentry/browser (incl. sendFeedback) 33.01 kB added added
@sentry/browser (incl. FeedbackAsync) 38.14 kB added added
@sentry/browser (incl. Metrics) 29.31 kB added added
@sentry/browser (incl. Logs) 29.55 kB added added
@sentry/browser (incl. Metrics & Logs) 30.22 kB added added
@sentry/react 30.02 kB added added
@sentry/react (incl. Tracing) 49.53 kB added added
@sentry/vue 34.1 kB added added
@sentry/vue (incl. Tracing) 49.61 kB added added
@sentry/svelte 28.24 kB added added
CDN Bundle 30.62 kB added added
CDN Bundle (incl. Tracing) 49.18 kB added added
CDN Bundle (incl. Logs, Metrics) 32.19 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) 50.49 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) 71.62 kB added added
CDN Bundle (incl. Tracing, Replay) 86.87 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.16 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 92.68 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 93.97 kB added added
CDN Bundle - uncompressed 91 kB added added
CDN Bundle (incl. Tracing) - uncompressed 148.26 kB added added
CDN Bundle (incl. Logs, Metrics) - uncompressed 95.71 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 152.24 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 221.06 kB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 268.08 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 272.05 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 281.78 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 285.74 kB added added
@sentry/nextjs (client) 52.18 kB added added
@sentry/sveltekit (client) 47.66 kB added added
@sentry/core/server 81.66 kB added added
@sentry/core/browser 67.73 kB added added
@sentry/node-core 64.04 kB added added
@sentry/node 127.22 kB added added
@sentry/node (incl. diagnostics channel injection) 171.41 kB added added
@sentry/node/import (ESM hook with diagnostics-channel injection) 166 B added added
@sentry/node/light 52.09 kB added added
@sentry/node - without tracing 75.82 kB added added
@sentry/aws-serverless 84.99 kB added added
@sentry/cloudflare (withSentry) - minified 204.93 kB added added
@sentry/cloudflare (withSentry) 505.2 kB added added

nicohrubec added a commit that referenced this pull request Oct 16, 2026
#25430)

Backport of: #25343

## Differences to the original PR

- `packages/cloudflare/src/vite/transform.ts`: on v10, a local class
already wrapped by a named export keeps its binding (which now points at
the wrapped class), so `export { Foo as default }` stays as written
instead of being re-pointed at a wrapper name.
- `packages/cloudflare/src/vite/autoInstrument.ts`, tests and the
`cloudflare-autoinstrument-package-entry` e2e app: small adjustments to
fit v10's code layout.

Heads-up: this conflicts with #25407 (backport of #25345) in
`packages/cloudflare/src/vite/transform.ts` and its test. Whichever
lands second needs a rebase.

This branch was prepared by the v10 backport automation, which was
blocked at PR creation; it's opened manually now.

<!-- junior-request-attribution:start -->
via **Jan Peer Stöcklmair**.
<!-- junior-request-attribution:end -->

<!-- junior-session-footer:start -->
<!-- junior-conversation-id:local%3Aweb%3A83fc948beed4fb12a54d41cb -->

--

[View Junior Session in
Sentry](https://sentry.sentry.io/explore/conversations/local%3Aweb%3A83fc948beed4fb12a54d41cb/?project=4510944073809921)

<!-- junior-session-footer:end -->

---------

Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
Co-authored-by: Nicolas Hrubec <nicolas.hrubec@outlook.com>
@isaacs
isaacs force-pushed the backport/v10-25345-cloudflare-default-reexport branch from 9186175 to a282dd0 Compare October 22, 2026 17:14
@isaacs

isaacs commented Oct 22, 2026

Copy link
Copy Markdown
Member

Bugbot run

@isaacs
isaacs marked this pull request as ready for review October 22, 2026 17:16
@isaacs
isaacs requested a review from a team as a code owner October 22, 2026 17:16
@isaacs
isaacs requested review from andreiborza and isaacs and removed request for a team October 22, 2026 17:16

@isaacs isaacs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a straightforward backport. Once the CI passes, I don't see any reason not to land it.

It's important to also backport #25372 and #25663 once this lands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants