Repository navigation
Conversation
logaretm
added this pull request to stack #25201
October 15, 2026 15:13
Contributor
size-limit report 📦
|
logaretm
force-pushed
the
awad/tunnel-tanstackstart
branch
from
October 15, 2026 15:36
2202cda to
46e486c
Compare
logaretm
force-pushed
the
awad/tunnel-tanstackstart
branch
3 times, most recently
from
October 15, 2026 17:15
9069686 to
b589186
Compare
logaretm
force-pushed
the
awad/tunnel-tanstackstart
branch
3 times, most recently
from
October 15, 2026 18:16
a5fcc1b to
f2a6beb
Compare
logaretm
force-pushed
the
awad/tunnel-tanstackstart
branch
2 times, most recently
from
October 15, 2026 18:28
722f4c6 to
eec9ddf
Compare
Member
Author
|
bugbot run |
logaretm
force-pushed
the
awad/tunnel-tanstackstart
branch
from
October 16, 2026 01:51
eec9ddf to
8d3dee9
Compare
Member
Author
|
bugbot run |
1 similar comment
Member
Author
|
bugbot run |
logaretm
force-pushed
the
awad/tunnel-tanstackstart
branch
from
October 16, 2026 02:25
8d3dee9 to
8c6c1fa
Compare
logaretm
force-pushed
the
awad/tunnel-tanstackstart
branch
2 times, most recently
from
October 16, 2026 14:00
6b24a7b to
64c909f
Compare
logaretm
force-pushed
the
awad/tunnel-tanstackstart
branch
from
October 19, 2026 19:12
c1c3595 to
58c71ae
Compare
logaretm
marked this pull request as ready for review
October 19, 2026 19:36
logaretm
requested review from
chargome and
s1gr1d
and removed request for
a team
October 19, 2026 19:36
…ntry
The Vite plugin now wraps the app's server entry, so `Sentry.init({ tunnel: true })`
works with no build option and tunnel requests are answered before Start's
request middleware and routing. Every `tunnelRoute` form is served the same way:
`true` uses the DSN-derived path instead of a random one per build, and a static
path no longer patches the generated route tree.
…th Start routes on
…nel's server entry wrapper
…lides with an app route, as on develop
…and serve it from there
…ith setManagedTunnelDefaults
…equests The tunnel handler now answers a request without one with a 411.
…ants, which other variants already cover
…the client tests that repeat core's
logaretm
force-pushed
the
awad/tunnel-tanstackstart
branch
from
October 19, 2026 20:08
58c71ae to
cdbac44
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cdbac44. Configure here.
| const serialized = defined?.define?.__SENTRY_TANSTACKSTART_TUNNEL_ROUTE__; | ||
| expect(typeof serialized).toBe('string'); | ||
| expect(serialized).toMatch(/^"\/[a-z0-9]{8}"$/); | ||
| expect(options._managedTunnel).toEqual({ basePath: '/app' }); |
There was a problem hiding this comment.
Vite tests leak tunnel defaults
Low Severity
The new configureServer tests call setManagedTunnelDefaults (via the plugin) but never reset that module-level state. Sibling wrap tests already use _INTERNAL_resetManagedTunnelDefaults in afterEach. Leftover tunnel/basePath defaults can bleed into later files in the same Vitest worker and flake assertions about which path is served. Flagged because the review rules call out tests that are likely to flake.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit cdbac44. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TanStack Start picked a random tunnel path per build and patched the generated route tree to serve it.
Because the new approach relies less on build-time, the logic was changed to wrap the server entrypoint instead and only route the matching tunnel requests to our handler.
This isn't a breaking change, previously we injected a single endpoint handler, now we inject a middleware since the DSN is only known at runtime.
closes #25461