Skip to content

fix(v10/bundler-plugins): Check globalThis before global in the injected snippet - #25507

Merged
JPeer264 merged 1 commit into
v10from
backport/v10/bundler-plugins-globalthis-first
Oct 19, 2026
Merged

JPeer264 merged 1 commit into
v10from
backport/v10/bundler-plugins-globalthis-first

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Backport of: #25365

Differences to the original PR

  • Dropped the packages/remix/src/v3/debugId.ts change: that file (the Remix v3 debug ID helper) doesn't exist on v10.
  • Integration-test snapshot conflicts (esbuild, rollup3/4, webpack5 fixtures, packages/bundler-plugins/test/rollup/public-api.test.ts) were resolved by keeping v10's snapshot output and applying the same globalThis-first reordering. fixtures/esbuild/basic-sourcemaps.test.ts was regenerated, so its sourcemap mappings match v10's esbuild output.

via Junior system actor junior.

--

View Junior Session [Sentry]

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 28.21 kB added added
@sentry/browser - with treeshaking flags 26.66 kB added added
@sentry/browser (incl. Tracing) 47.23 kB added added
@sentry/browser (incl. Tracing + Span Streaming) 49.03 kB added added
@sentry/browser (incl. Tracing, Profiling) 52.02 kB added added
@sentry/browser (incl. Tracing, Replay) 86.64 kB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 76.27 kB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 91.35 kB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 103.97 kB added added
@sentry/browser (incl. Feedback) 45.38 kB added added
@sentry/browser (incl. sendFeedback) 33.01 kB added added
@sentry/browser (incl. FeedbackAsync) 38.14 kB added added
@sentry/browser (incl. Metrics) 29.31 kB added added
@sentry/browser (incl. Logs) 29.55 kB added added
@sentry/browser (incl. Metrics & Logs) 30.22 kB added added
@sentry/react 30.02 kB added added
@sentry/react (incl. Tracing) 49.53 kB added added
@sentry/vue 34.1 kB added added
@sentry/vue (incl. Tracing) 49.61 kB added added
@sentry/svelte 28.24 kB added added
CDN Bundle 30.62 kB added added
CDN Bundle (incl. Tracing) 49.18 kB added added
CDN Bundle (incl. Logs, Metrics) 32.19 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) 50.49 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) 71.62 kB added added
CDN Bundle (incl. Tracing, Replay) 86.87 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.16 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 92.68 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 93.97 kB added added
CDN Bundle - uncompressed 91 kB added added
CDN Bundle (incl. Tracing) - uncompressed 148.26 kB added added
CDN Bundle (incl. Logs, Metrics) - uncompressed 95.71 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 152.24 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 221.06 kB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 268.08 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 272.05 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 281.78 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 285.74 kB added added
@sentry/nextjs (client) 52.1 kB added added
@sentry/sveltekit (client) 47.66 kB added added
@sentry/core/server 81.62 kB added added
@sentry/core/browser 67.67 kB added added
@sentry/node-core 64.04 kB added added
@sentry/node 127.22 kB added added
@sentry/node (incl. diagnostics channel injection) 171.41 kB added added
@sentry/node/import (ESM hook with diagnostics-channel injection) 166 B added added
@sentry/node/light 52.09 kB added added
@sentry/node - without tracing 75.82 kB added added
@sentry/aws-serverless 84.99 kB added added
@sentry/cloudflare (withSentry) - minified 204.93 kB added added
@sentry/cloudflare (withSentry) 505.2 kB added added

@JPeer264
JPeer264 marked this pull request as ready for review October 19, 2026 14:18
@JPeer264
JPeer264 requested a review from a team as a code owner October 19, 2026 14:18
@JPeer264
JPeer264 requested review from chargome, nicohrubec and s1gr1d and removed request for a team and chargome October 19, 2026 14:18
@JPeer264
JPeer264 merged commit 075c21c into v10 Oct 19, 2026
97 checks passed
@JPeer264
JPeer264 deleted the backport/v10/bundler-plugins-globalthis-first branch October 19, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants