Repository navigation
fix(v10/bundler-plugins): Check globalThis before global in the injected snippet - #25507
Merged
Merged
Conversation
…njected snippet Backport of: #25365
Contributor
size-limit report 📦
|
JPeer264
marked this pull request as ready for review
October 19, 2026 14:18
JPeer264
requested review from
chargome,
nicohrubec and
s1gr1d
and removed request for
a team and
chargome
October 19, 2026 14:18
nicohrubec
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #25365
Differences to the original PR
packages/remix/src/v3/debugId.tschange: that file (the Remix v3 debug ID helper) doesn't exist on v10.packages/bundler-plugins/test/rollup/public-api.test.ts) were resolved by keeping v10's snapshot output and applying the sameglobalThis-first reordering.fixtures/esbuild/basic-sourcemaps.test.tswas regenerated, so its sourcemap mappings match v10's esbuild output.via Junior system actor
junior.--
View Junior Session [Sentry]