Repository navigation
ci(e2e): Stop pnpm run from installing the workspace in E2E jobs - #25514
Merged
Merged
Conversation
Since #25403, E2E jobs no longer restore the root node_modules. pnpm then installs the whole workspace before the first `pnpm run` in dev-packages/e2e-tests, which took about 26s per job. Next to the background Playwright install, its npx sometimes picked up the half-installed root playwright and failed with "playwright: not found". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
marked this pull request as ready for review
October 19, 2026 10:55
JPeer264
approved these changes
Oct 19, 2026
A background composite action sets up its steps from the job's shared github context. When a foreground step starts at that moment, the runner fails with "Collection was modified; enumeration operation may not execute". With the workspace install gone, the foreground steps start quickly enough to hit this in a few jobs per run. The E2E jobs only need chromium, so download it directly instead of restoring the cache of all browsers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
marked this pull request as draft
October 19, 2026 14:16
…e the build Instead of replacing the action, start it where the next foreground step runs for a while. Without the workspace install, the steps before the build take well under a second, so this barely shortens the overlap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #25403, E2E jobs no longer restore the root
node_modules. pnpm then installs all 63 workspace projects before the firstpnpm run test:prepare, becauseverify-deps-before-runfinds the dependencies missing. That's about 26s per E2E job, which cancels out most of what #25403 saved. It also made the background Playwright install flaky: itsnpxran from the repo root and could find the hoistednode_modules/playwrightbefore pnpm had linked its binary (playwright: not found). The scripts run withpnpm runhere are plainnodescripts, so disabling the check is enough. It's set per job, so local runs keep it.Without the long install, the foreground steps start in quick succession, which exposes a runner bug. The runner sets up the steps of a background composite action from the job's shared
githubcontext (CompositeActionHandler.cs→GitHubContext.ShallowCopy()). If a foreground step starts at that moment, this fails withCollection was modified; enumeration operation may not execute. The background install now starts right before the app build, so nothing else starts while it sets up. The steps it no longer overlaps with take well under a second.🤖 Generated with Claude Code