Skip to content

fix(aws-serverless): End the function.aws span when a callback-style handler calls back - #25543

Open
4ktLuffy wants to merge 1 commit into
getsentry:developfrom
4ktLuffy:fix/aws-lambda-callback-span
Open

4ktLuffy wants to merge 1 commit into
getsentry:developfrom
4ktLuffy:fix/aws-lambda-callback-span

Conversation

@4ktLuffy

Copy link
Copy Markdown
Contributor

For callback-style handlers the function.aws span ended as soon as the handler returned, so it had ~0 ms duration and ok status even when callback(err) came later. If the handler takes a callback and doesn't return a promise, the span is now ended by the wrapped callback instead. Tests call back from a setTimeout with a result and with an error.

@4ktLuffy
4ktLuffy requested a review from a team as a code owner October 19, 2026 19:18
@4ktLuffy
4ktLuffy requested review from JPeer264 and mydea and removed request for a team October 19, 2026 19:18
@github-actions github-actions Bot added the external PR from an external contributor label Oct 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external PR from an external contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant