Repository navigation
ci: Share the E2E test setup between build.yml and optional-e2e.yml - #25616
Merged
Merged
Conversation
Moves the steps that prepare a test application into a composite action, so the required and optional E2E jobs cannot drift apart. Playwright, the build and the test run stay in the workflows, because a composite action cannot declare background steps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
added this pull request to stack #25617
October 21, 2026 12:39
Contributor
size-limit report 📦Compared: 98df61f (PR test merge using ab/optional-e2e-workflow at 9350429) Against: 5e2b904 (ab/optional-e2e-workflow) · base run #62910
|
andreiborza
approved these changes
Oct 21, 2026
andreiborza
left a comment
andreiborza
left a comment
Member
There was a problem hiding this comment.
Nice, good idea to split this up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #25548.
The optional E2E workflow copied most of `job_e2e_tests` from build.yml, so the two could drift apart. The steps that prepare a test application (runtimes, artifact downloads including the AWS ones, prepare/validate, copy to temp, pnpm overrides) now live in `.github/actions/prepare-e2e-test`. The action downloads from the current run by default; optional-e2e.yml passes the build.yml run ID and a token instead.
Installing Playwright, building and running the test stay in the workflows: Playwright installs as a background step, and a composite action cannot declare background steps.
🤖 Generated with Claude Code