Repository navigation
test(cloudflare): Add Workers AI E2E test for Clairic - #25625
Draft
andreiborza wants to merge 1 commit into
Draft
andreiborza wants to merge 1 commit into
andreiborza wants to merge 1 commit into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4b85e32. Configure here.
| 'gen_ai.response.model': expect.stringContaining('clairic'), | ||
| 'gen_ai.input.messages': expect.stringContaining('Northwind Supply'), | ||
| 'gen_ai.output.messages': expect.stringContaining('INV-2291'), | ||
| }); |
There was a problem hiding this comment.
E2E test uses hardcoded attribute names
Low Severity
The new Clairic E2E assertions hard-code span attribute keys such as gen_ai.operation.name, gen_ai.request.model, gen_ai.response.model, gen_ai.input.messages, and gen_ai.output.messages. Testing conventions require those keys to come from @sentry/conventions constants rather than string literals.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 4b85e32. Configure here.
Contributor
size-limit report 📦Compared: 0907510 (PR test merge using develop at 6e6e13f) Against: 6fb6b07 (develop) · base run #62924
|
andreiborza
added this pull request to stack #25627
October 21, 2026 14:11
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andreiborza
force-pushed
the
ab/workers-ai-clairic-tests
branch
from
October 21, 2026 14:24
4b85e32 to
67c87cb
Compare
andreiborza
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a real Worker E2E test that calls Clairic and checks the
gen_ai.extractspan in Sentry.Why
The E2E test calls the real model, so it confirms the response shape that the binding returns.
Closes: #25615