Repository navigation
feat(deps): Bump @opentelemetry/api to 1.10.0 - #25629
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andreiborza
marked this pull request as ready for review
October 21, 2026 15:49
andreiborza
requested review from
mydea,
nicohrubec and
s1gr1d
and removed request for
a team
October 21, 2026 15:49
mydea
reviewed
Oct 21, 2026
| public startSpan(name: string, options?: SpanOptions): Span { | ||
| return startInactiveSpan({ | ||
| ...options, | ||
| links: options?.links as SpanLink[] | undefined, |
Member
Author
There was a problem hiding this comment.
Yea unfortunately, alternative is we widen our type and pass the pain on to users.
Member
There was a problem hiding this comment.
since we have this in a few places. can we add a utility to handle this, e.g. links: convertSpanLinkType(options?.links), then we could theoretically also properly cast this at some point if needed, and it is a bit clearer what this does/why it does it?
Member
There was a problem hiding this comment.
(IMHO that utility could for now just cast this the same way as it is here, but it would be a bit encapsulated)
Member
Author
There was a problem hiding this comment.
Added convertSpanLinkType to @sentry/opentelemetry and @sentry/deno. I didn't want to export this via core, hence the per-package helpers. Updated in c3387e4
mydea
reviewed
Oct 21, 2026
|
|
||
| const spanOpts = { | ||
| ...opts, | ||
| links: opts.links as SpanLink[] | undefined, |
Contributor
size-limit report 📦Compared: 9cf5551 (PR test merge using develop at b3e0c9e) Against: b3e0c9e (develop) · base run #63030 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 2 failing, 62 successful. See the run.
Successful checks
|
andreiborza
force-pushed
the
ab/bump-otel-api
branch
from
October 21, 2026 16:16
57d6a57 to
c3387e4
Compare
mydea
approved these changes
Oct 21, 2026
51 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump
@opentelemetry/apito 1.10.0 in all SDK packages. The peer range of@sentry/opentelemetrystays at^1.9.0.Why
1.10.0 changes OTel attribute values to
unknown. Our tracers and the SvelteKit handler need small type changes so they compile with the new types. Runtime behavior does not change.