Repository navigation
ci: Drop the TS 5.0 run of the Node integration tests - #25664
Closed
sentry-junior[bot] wants to merge 1 commit into
Closed
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
The scenarios run through tsx, which strips types without checking them, so the TypeScript version installed by use-ts-5_0.js does not change what these jobs test. TS 5.0 type compatibility is covered by the generic-ts5.0 E2E app. Co-Authored-By: Joshua Li <14209781+joshuarli@users.noreply.github.com>
Contributor
size-limit report 📦Compared: 4aa1ded (PR test merge using develop at 40eff80) Against: 40eff80 (develop) · base run #63186 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 10 failing, 54 successful. See the run.
Successful checks
|
Contributor
Author
|
Superseded by #25668, which combines these CI changes so the suite runs once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Node (24) (TS 5.0)shards no longer test anything that the plain Node 24 shards don't already cover. Scenarios now load throughtsx/cjs, which strips types without checking them, so thetypescript@5.0.4thatuse-ts-5_0.jsinstalls never affects a test. The one suite that runstsc(prisma-orm-v7) installs its owntypescript@^5.9.0in its tmp dir. TS 5.0 type compatibility of the published packages is still checked by thegeneric-ts5.0E2E app.The shards cost a lot anyway. They take three large runners per run, and each one spends 1–8 min in
pnpm add --workspace-root, which re-resolves the whole workspace. That step took 2–8 min on PRs today, making these the slowest Node integration jobs (about 10 min vs about 2–3 min). They were also the integration jobs that failed most often in the runs I sampled (7 of 16 first attempts). The failures were the same Prisma setup-hook timeouts the other Node versions hit, so dropping them removes one more chance to flake per run.via @joshuarli.
--
View Junior Session [Sentry]