Repository navigation
ci: Keep the runner's apt packages when installing Playwright - #25666
Closed
sentry-junior[bot] wants to merge 1 commit into
Closed
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
`playwright install --with-deps` names system libraries that the runner image already has, so apt-get upgrades them to the latest Ubuntu update. That is half of the download when the apt cache is cold. Co-Authored-By: Joshua Li <14209781+joshuarli@users.noreply.github.com>
Contributor
size-limit report 📦Compared: 40d0c45 (PR test merge using develop at 40eff80) Against: 40eff80 (develop) · base run #63186 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 4 failing, 60 successful. See the run.
Successful checks
|
Contributor
Author
|
Superseded by #25668, which combines these CI changes so the suite runs once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install Playwrightis the longest step in the slowest jobs. Most of the time it takes seconds, but in the runs I sampled more than a dozen E2E and browser jobs spent 7–16 min in it. Those jobs set the wall time:E2E nextjs-app-dirtook 15 min, of which 12 were the install, andPlaywright esm (2/4)took 17 min, of which 15.5 were the install. In those jobs the apt cache was missing from the volume (Some cache paths missing: ... /var/cache/apt/archives/), soapt-getdownloaded all 42 MB fromazure.archive.ubuntu.comat 50–80 kB/s.Half of those 42 MB is not new packages.
playwright install --with-depsnames libraries that the image already has (glib, mesa, nss, x11, freetype, xvfb), andapt-get installupgrades named packages that are already installed. That is 24 upgrades and 21 MB, on top of 9 new font packages. SettingAPT::Get::Upgrade "false"keeps the image versions but still installs the missing packages. I checked this in anubuntu:24.04container: apt printsSkipping libx11-6, it is already installed and upgrade is not set, installs the new package, and exits 0.This doesn't fix the missing apt cache, but it about halves the worst case. It also stops new Ubuntu security updates from causing apt cache misses when the cache is there.
via @joshuarli.
--
View Junior Session [Sentry]