Repository navigation
fix(core): Drop sampled-out errors before they take a promise buffer slot - #25751
Merged
Merged
Conversation
…slot Since errors are sampled after beforeSend, a sampled-out error ran the whole event pipeline while holding a slot in the client's promise buffer. With an async event processor (e.g. ContextLines on Node), a burst of errors filled the buffer and dropped errors that would have been sent as queue_overflow. The pipeline only matters for a sampled-out error when there is an ok session it can update, so without one the error is now dropped right away.
Contributor
size-limit report 📦Compared: 5f923e0 (PR test merge using develop at 869b92c) Against: 869b92c (develop) · base run #63667 ✅ Baseline matches: this diff contains only this PR's changes.
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7df9aa3. Configure here.
logaretm
marked this pull request as ready for review
October 27, 2026 02:48
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 3 not successful, 59 successful. See the run.
Successful checks
|
s1gr1d
approved these changes
Oct 27, 2026
logaretm
added a commit
that referenced
this pull request
Oct 27, 2026
…fer slot (#25753) Backport of: #25751 ## Differences to the original PR - `packages/core/test/lib/client.test.ts`: the "does not set lastEventId" test passes an explicit `event_id` and asserts `lastEventId()` isn't it, instead of asserting `undefined`. v10's test setup doesn't reset `lastEventId` between tests, so an earlier test's ID leaks in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #22671 sampled-out errors run the whole event pipeline while holding a client buffer slot, so error bursts on Node fill it up and real errors get dropped as queue_overflow, fixed by dropping sampled-out errors right away when there is no ok session for them to update.
I added tests showing sampled-out errors no longer overflow the buffer without a session and still go through the pipeline when one exists.