Skip to content

chore: Update PR template and prompt agent to use it - #25763

Merged
s1gr1d merged 3 commits into
developfrom
sig/update-pr-template
Oct 27, 2026
Merged

s1gr1d merged 3 commits into
developfrom
sig/update-pr-template

Conversation

@s1gr1d

@s1gr1d s1gr1d commented Oct 27, 2026

Copy link
Copy Markdown
Member

Updates the PR template we have on GitHub and also makes agents use it.

The PR template contains the most important review and PR guidelines.

@@ -1,8 +1,23 @@
Before submitting a pull request, please take a look at our
[Contributing](https://github.com/getsentry/sentry-javascript/blob/develop/CONTRIBUTING.md) guidelines and verify:
<!--

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything that's not actually a template, but a "check this first" is now within a comment so it's clear what's the template and what is just some extra text.

@s1gr1d
s1gr1d requested review from Lms24, msonnb and mydea October 27, 2026 14:18
Comment on lines +17 to +19
**How to review:** <!-- where to start, what to skim -->

**Unsure about:** <!-- where you want a second opinion -->

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue that these two could be optional, depending on the change ("Why" on the other hand I think is always relevant). I don't really have a better suggestion though (other than mentioning them in the comment above), so from my end we can just go with it and see if it becomes noisy/unhelpful.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind, just saw - Remove fields that do not apply (e.g. small PRs). a few lines above 😅

Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
@s1gr1d
s1gr1d enabled auto-merge (squash) October 27, 2026 17:07
@s1gr1d
s1gr1d merged commit c573f4e into develop Oct 27, 2026
37 checks passed
@s1gr1d
s1gr1d deleted the sig/update-pr-template branch October 27, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants