Skip to content

ref(browser-utils): Use convention constants for attribute keys - #25896

Merged
msonnb merged 1 commit into
developfrom
ms/browser-utils-attribute-conventions
Oct 29, 2026
Merged

ref(browser-utils): Use convention constants for attribute keys#25896
msonnb merged 1 commit into
developfrom
ms/browser-utils-attribute-conventions

Conversation

@msonnb

@msonnb msonnb commented Oct 29, 2026

Copy link
Copy Markdown
Member

Why: Use shared constants for resource timing, web vitals, device information, and element-timing attributes. Legacy attribute names are preserved, including where that requires deprecated constants.

How to review: Compare each imported constant with the literal it replaces; emitted attribute names stay unchanged.

@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Compared: db6101f (PR test merge using develop at f7b6364)

Against: f7b6364 (develop) · base run #64148

✅ Baseline matches: this diff contains only this PR's changes.

Path Size % Change Change
@sentry/browser 30.43 kB - -
@sentry/browser - with treeshaking flags 28.53 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 28.44 kB - -
@sentry/browser (incl. Tracing) 52.76 kB +0.13% +66 B 🔺
@sentry/browser (incl. Tracing + Span Streaming) 52.76 kB +0.12% +59 B 🔺
@sentry/browser (incl. Tracing, Profiling) 55.72 kB +0.18% +96 B 🔺
@sentry/browser (incl. Tracing, Replay) 93.04 kB +0.1% +86 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.58 kB +0.05% +34 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 97.77 kB +0.09% +85 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 110.76 kB +0.1% +103 B 🔺
@sentry/browser (incl. Feedback) 47.98 kB - -
@sentry/browser (incl. sendFeedback) 35.51 kB - -
@sentry/browser (incl. FeedbackAsync) 40.61 kB - -
@sentry/browser (incl. Metrics) 31.43 kB - -
@sentry/browser (incl. Logs) 31.71 kB - -
@sentry/browser (incl. Metrics & Logs) 32.39 kB - -
@sentry/react 32.22 kB - -
@sentry/react (incl. Tracing) 55.06 kB +0.2% +108 B 🔺
@sentry/vue 38.71 kB - -
@sentry/vue (incl. Tracing) 55.63 kB +0.11% +57 B 🔺
@sentry/svelte 30.45 kB - -
@sentry/remix (Remix 3 client bundle) 57.83 kB +0.17% +94 B 🔺
CDN Bundle 32.15 kB - -
CDN Bundle (incl. Tracing) 53.23 kB +0.07% +37 B 🔺
CDN Bundle (incl. Logs, Metrics) 34.39 kB +0.07% +23 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) 55.16 kB +0.07% +36 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 75.82 kB +0.02% +15 B 🔺
CDN Bundle (incl. Tracing, Replay) 91.39 kB +0.05% +43 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 93.38 kB +0.07% +65 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 97.54 kB +0.08% +77 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 99.56 kB +0.09% +80 B 🔺
CDN Bundle - uncompressed 94.59 kB - -
CDN Bundle (incl. Tracing) - uncompressed 157.68 kB +0.07% +104 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 101.14 kB -0.01% -3 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 163.65 kB +0.07% +101 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 232.7 kB -0.01% -3 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 279.37 kB +0.04% +104 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 285.32 kB +0.04% +101 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 293.07 kB +0.04% +104 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 299.01 kB +0.04% +101 B 🔺
@sentry/nextjs (client) 57.91 kB +0.16% +91 B 🔺
@sentry/sveltekit (client) 53.21 kB +0.14% +74 B 🔺
@sentry/core/server 44.34 kB - -
@sentry/core/browser 13.95 kB - -
@sentry/node 155.15 kB +0.02% +18 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 81.67 kB - -
@sentry/node - without tracing 95.89 kB +0.03% +22 B 🔺
@sentry/node - without channel injection 135.78 kB +0.02% +25 B 🔺
@sentry/aws-serverless 104.05 kB +0.03% +23 B 🔺
@sentry/cloudflare (withSentry) - minified 198.04 kB - -
@sentry/cloudflare (withSentry) 491.9 kB - -
@sentry/nextjs/cloudflare (withSentry) - minified 218.62 kB - -

View base workflow run

@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Optional E2E tests

Some optional checks were not successful. They do not block the merge. 1 not successful, 22 successful. See the run.

Check Status
❌ CI: Optional E2E Tests / E2E supabase-nextjs Test (optional) Failing after 51s Details
Successful checks
Check Status
✅ CI: Optional E2E Tests / E2E astro-7 Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-14 (latest) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps Test (optional) Successful in 27s Details
✅ CI: Optional E2E Tests / E2E nextjs-15 (latest) Test (optional) Successful in 3m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (vinext, bun) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (cloudflare, latest) Test (optional) Successful in 3m Details
✅ CI: Optional E2E Tests / E2E nextjs-orpc Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-16-tunnel (cloudflare) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-15 (turbo) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E astro-7-static Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-cloudflare Test (optional) Successful in 42s Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (vinext) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-sourcemaps Test (optional) Successful in 59s Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nuxt-5 Test (optional) Successful in 3m Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (client source maps kept) Test (optional) Successful in 25s Details
✅ CI: Optional E2E Tests / E2E react-router-7-framework-instrumentation Test (optional) Successful in 3m Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (static / nuxt generate) Test (optional) Successful in 38s Details
✅ CI: Optional E2E Tests / E2E react-send-to-sentry Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (deno) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E vue-3 (no Options API) Test (optional) Successful in 57s Details
✅ CI: Optional E2E Tests / E2E solidstart-2 Test (optional) Successful in 48s Details

@andreiborza andreiborza changed the title refactor(browser-utils): Use convention constants for attribute keys ref(browser-utils): Use convention constants for attribute keys Oct 29, 2026
@msonnb
msonnb marked this pull request as ready for review October 29, 2026 15:47
@msonnb
msonnb requested a review from a team as a code owner October 29, 2026 15:47
@msonnb
msonnb requested review from Lms24 and logaretm and removed request for a team October 29, 2026 15:47
@msonnb
msonnb merged commit efe1e26 into develop Oct 29, 2026
269 of 270 checks passed
@msonnb
msonnb deleted the ms/browser-utils-attribute-conventions branch October 29, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreiborza andreiborza andreiborza approved these changes
@logaretm logaretm Awaiting requested review from logaretm logaretm is a code owner automatically assigned from getsentry/team-javascript-sdks-browser
@Lms24 Lms24 Awaiting requested review from Lms24 Lms24 is a code owner automatically assigned from getsentry/team-javascript-sdks-browser

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@msonnb @andreiborza