Repository navigation
test(bundler-plugins): Add integration tests for sourcemaps.assets and sourcemaps.ignore
#25916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
timfish
wants to merge
1
commit into
develop
Choose a base branch
from
feat/bundler-plugin-integration-tests-assets-ignore
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+557
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
dev-packages/bundler-plugin-integration-tests/fixtures/configs/sourcemaps-assets.config.d.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| import type { SentryRollupPluginOptions } from "@sentry/bundler-plugins/rollup"; | ||
| export declare const sentryConfig: SentryRollupPluginOptions; |
10 changes: 10 additions & 0 deletions
10
dev-packages/bundler-plugin-integration-tests/fixtures/configs/sourcemaps-assets.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| export const sentryConfig = { | ||
| telemetry: false, | ||
| authToken: "fake-auth", | ||
| org: "fake-org", | ||
| project: "fake-project", | ||
| release: { inject: false }, | ||
| sourcemaps: { | ||
| assets: ["out/sourcemaps-assets/entry1.js"], | ||
| }, | ||
| }; |
2 changes: 2 additions & 0 deletions
2
dev-packages/bundler-plugin-integration-tests/fixtures/configs/sourcemaps-ignore.config.d.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| import type { SentryRollupPluginOptions } from "@sentry/bundler-plugins/rollup"; | ||
| export declare const sentryConfig: SentryRollupPluginOptions; |
10 changes: 10 additions & 0 deletions
10
dev-packages/bundler-plugin-integration-tests/fixtures/configs/sourcemaps-ignore.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| export const sentryConfig = { | ||
| telemetry: false, | ||
| authToken: "fake-auth", | ||
| org: "fake-org", | ||
| project: "fake-project", | ||
| release: { inject: false }, | ||
| sourcemaps: { | ||
| ignore: ["**/entry2.js"], | ||
| }, | ||
| }; |
15 changes: 15 additions & 0 deletions
15
dev-packages/bundler-plugin-integration-tests/fixtures/esbuild/sourcemaps-assets.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import * as esbuild from "esbuild"; | ||
| import { sentryEsbuildPlugin } from "@sentry/bundler-plugins/esbuild"; | ||
| import { sentryConfig } from "../configs/sourcemaps-assets.config.js"; | ||
|
|
||
| await esbuild.build({ | ||
| entryPoints: ["./src/entry1.js", "./src/entry2.js"], | ||
| bundle: true, | ||
| outdir: "./out/sourcemaps-assets", | ||
| minify: false, | ||
| format: "esm", | ||
| splitting: true, | ||
| chunkNames: "[name]", | ||
| sourcemap: true, | ||
| plugins: [sentryEsbuildPlugin(sentryConfig)], | ||
| }); |
36 changes: 36 additions & 0 deletions
36
dev-packages/bundler-plugin-integration-tests/fixtures/esbuild/sourcemaps-assets.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import { expect } from "vitest"; | ||
| import { test } from "./utils"; | ||
|
|
||
| test(import.meta.url, ({ runBundler, readOutputFiles }) => { | ||
| runBundler({ SENTRY_TEST_RECORD_UPLOADED_SOURCES: "1" }); | ||
| const files = readOutputFiles(); | ||
|
|
||
| expect(Object.keys(files).sort()).toMatchInlineSnapshot(` | ||
| [ | ||
| "chunk.js", | ||
| "chunk.js.map", | ||
| "entry1.js", | ||
| "entry1.js.map", | ||
| "entry2.js", | ||
| "entry2.js.map", | ||
| "sentry-cli-mock.json", | ||
| "sentry-uploaded-sources.json", | ||
| ] | ||
| `); | ||
| expect(JSON.parse(files["sentry-uploaded-sources.json"]!)).toMatchInlineSnapshot(` | ||
| [ | ||
| [ | ||
| "sentry-debug-id-stub:_sentry-debug-id-injection-stub?sentry-module-id=00000000-0000-0000-0000-000000000000", | ||
| "../../src/entry1.js", | ||
| "../../src/entry1.js", | ||
| ], | ||
| ] | ||
| `); | ||
| expect(files["sentry-cli-mock.json"]).toMatchInlineSnapshot(` | ||
| "["release","create","CURRENT_SHA","--project","fake-project"], | ||
| ["release","set-commits","CURRENT_SHA","--auto"], | ||
| ["release","finalize","CURRENT_SHA"], | ||
| ["sourcemap","upload","-p","fake-project","--release","CURRENT_SHA","sentry-bundler-plugin-upload-path"], | ||
| " | ||
| `); | ||
| }); |
15 changes: 15 additions & 0 deletions
15
dev-packages/bundler-plugin-integration-tests/fixtures/esbuild/sourcemaps-ignore.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import * as esbuild from "esbuild"; | ||
| import { sentryEsbuildPlugin } from "@sentry/bundler-plugins/esbuild"; | ||
| import { sentryConfig } from "../configs/sourcemaps-ignore.config.js"; | ||
|
|
||
| await esbuild.build({ | ||
| entryPoints: ["./src/entry1.js", "./src/entry2.js"], | ||
| bundle: true, | ||
| outdir: "./out/sourcemaps-ignore", | ||
| minify: false, | ||
| format: "esm", | ||
| splitting: true, | ||
| chunkNames: "[name]", | ||
| sourcemap: true, | ||
| plugins: [sentryEsbuildPlugin(sentryConfig)], | ||
| }); |
36 changes: 36 additions & 0 deletions
36
dev-packages/bundler-plugin-integration-tests/fixtures/esbuild/sourcemaps-ignore.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import { expect } from "vitest"; | ||
| import { test } from "./utils"; | ||
|
|
||
| test(import.meta.url, ({ runBundler, readOutputFiles }) => { | ||
| runBundler({ SENTRY_TEST_RECORD_UPLOADED_SOURCES: "1" }); | ||
| const files = readOutputFiles(); | ||
|
|
||
| expect(Object.keys(files).sort()).toMatchInlineSnapshot(` | ||
| [ | ||
| "chunk.js", | ||
| "chunk.js.map", | ||
| "entry1.js", | ||
| "entry1.js.map", | ||
| "entry2.js", | ||
| "entry2.js.map", | ||
| "sentry-cli-mock.json", | ||
| "sentry-uploaded-sources.json", | ||
| ] | ||
| `); | ||
| expect(JSON.parse(files["sentry-uploaded-sources.json"]!)).toMatchInlineSnapshot(` | ||
| [ | ||
| [ | ||
| "sentry-debug-id-stub:_sentry-debug-id-injection-stub?sentry-module-id=00000000-0000-0000-0000-000000000000", | ||
| "../../src/entry1.js", | ||
| "../../src/entry1.js", | ||
| ], | ||
| ] | ||
| `); | ||
| expect(files["sentry-cli-mock.json"]).toMatchInlineSnapshot(` | ||
| "["release","create","CURRENT_SHA","--project","fake-project"], | ||
| ["release","set-commits","CURRENT_SHA","--auto"], | ||
| ["release","finalize","CURRENT_SHA"], | ||
| ["sourcemap","upload","-p","fake-project","--release","CURRENT_SHA","sentry-bundler-plugin-upload-path"], | ||
| " | ||
| `); | ||
| }); |
13 changes: 13 additions & 0 deletions
13
dev-packages/bundler-plugin-integration-tests/fixtures/rolldown/sourcemaps-assets.config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import { sentryRollupPlugin } from "@sentry/bundler-plugins/rollup"; | ||
| import { defineConfig } from "rolldown"; | ||
| import { sentryConfig } from "../configs/sourcemaps-assets.config.js"; | ||
|
|
||
| export default defineConfig({ | ||
| input: ["src/entry1.js", "src/entry2.js"], | ||
| output: { | ||
| dir: "out/sourcemaps-assets", | ||
| chunkFileNames: "[name].js", | ||
| sourcemap: true, | ||
| }, | ||
| plugins: [sentryRollupPlugin(sentryConfig)], | ||
| }); |
34 changes: 34 additions & 0 deletions
34
dev-packages/bundler-plugin-integration-tests/fixtures/rolldown/sourcemaps-assets.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import { expect } from "vitest"; | ||
| import { test } from "./utils"; | ||
|
|
||
| test(import.meta.url, ({ runBundler, readOutputFiles }) => { | ||
| runBundler({ SENTRY_TEST_RECORD_UPLOADED_SOURCES: "1" }); | ||
| const files = readOutputFiles(); | ||
|
|
||
| expect(Object.keys(files).sort()).toMatchInlineSnapshot(` | ||
| [ | ||
| "common.js", | ||
| "common.js.map", | ||
| "entry1.js", | ||
| "entry1.js.map", | ||
| "entry2.js", | ||
| "entry2.js.map", | ||
| "sentry-cli-mock.json", | ||
| "sentry-uploaded-sources.json", | ||
| ] | ||
| `); | ||
| expect(JSON.parse(files["sentry-uploaded-sources.json"]!)).toMatchInlineSnapshot(` | ||
| [ | ||
| [ | ||
| "../../src/entry1.js", | ||
| ], | ||
| ] | ||
| `); | ||
| expect(files["sentry-cli-mock.json"]).toMatchInlineSnapshot(` | ||
| "["release","create","CURRENT_SHA","--project","fake-project"], | ||
| ["release","set-commits","CURRENT_SHA","--auto"], | ||
| ["release","finalize","CURRENT_SHA"], | ||
| ["sourcemap","upload","-p","fake-project","--release","CURRENT_SHA","sentry-bundler-plugin-upload-path"], | ||
| " | ||
| `); | ||
| }); |
13 changes: 13 additions & 0 deletions
13
dev-packages/bundler-plugin-integration-tests/fixtures/rolldown/sourcemaps-ignore.config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import { sentryRollupPlugin } from "@sentry/bundler-plugins/rollup"; | ||
| import { defineConfig } from "rolldown"; | ||
| import { sentryConfig } from "../configs/sourcemaps-ignore.config.js"; | ||
|
|
||
| export default defineConfig({ | ||
| input: ["src/entry1.js", "src/entry2.js"], | ||
| output: { | ||
| dir: "out/sourcemaps-ignore", | ||
| chunkFileNames: "[name].js", | ||
| sourcemap: true, | ||
| }, | ||
| plugins: [sentryRollupPlugin(sentryConfig)], | ||
| }); |
37 changes: 37 additions & 0 deletions
37
dev-packages/bundler-plugin-integration-tests/fixtures/rolldown/sourcemaps-ignore.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import { expect } from "vitest"; | ||
| import { test } from "./utils"; | ||
|
|
||
| test(import.meta.url, ({ runBundler, readOutputFiles }) => { | ||
| runBundler({ SENTRY_TEST_RECORD_UPLOADED_SOURCES: "1" }); | ||
| const files = readOutputFiles(); | ||
|
|
||
| expect(Object.keys(files).sort()).toMatchInlineSnapshot(` | ||
| [ | ||
| "common.js", | ||
| "common.js.map", | ||
| "entry1.js", | ||
| "entry1.js.map", | ||
| "entry2.js", | ||
| "entry2.js.map", | ||
| "sentry-cli-mock.json", | ||
| "sentry-uploaded-sources.json", | ||
| ] | ||
| `); | ||
| expect(JSON.parse(files["sentry-uploaded-sources.json"]!)).toMatchInlineSnapshot(` | ||
| [ | ||
| [ | ||
| "../../src/common.js", | ||
| ], | ||
| [ | ||
| "../../src/entry1.js", | ||
| ], | ||
| ] | ||
| `); | ||
| expect(files["sentry-cli-mock.json"]).toMatchInlineSnapshot(` | ||
| "["release","create","CURRENT_SHA","--project","fake-project"], | ||
| ["release","set-commits","CURRENT_SHA","--auto"], | ||
| ["release","finalize","CURRENT_SHA"], | ||
| ["sourcemap","upload","-p","fake-project","--release","CURRENT_SHA","sentry-bundler-plugin-upload-path"], | ||
| " | ||
| `); | ||
| }); |
13 changes: 13 additions & 0 deletions
13
dev-packages/bundler-plugin-integration-tests/fixtures/rollup4/sourcemaps-assets.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import { sentryRollupPlugin } from "@sentry/bundler-plugins/rollup"; | ||
| import { defineConfig } from "rollup"; | ||
| import { sentryConfig } from "../configs/sourcemaps-assets.config.js"; | ||
|
|
||
| export default defineConfig({ | ||
| input: ["src/entry1.js", "src/entry2.js"], | ||
| output: { | ||
| dir: "out/sourcemaps-assets", | ||
| chunkFileNames: "[name].js", | ||
| sourcemap: true, | ||
| }, | ||
| plugins: [sentryRollupPlugin(sentryConfig)], | ||
| }); |
34 changes: 34 additions & 0 deletions
34
dev-packages/bundler-plugin-integration-tests/fixtures/rollup4/sourcemaps-assets.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import { expect } from "vitest"; | ||
| import { test } from "./utils"; | ||
|
|
||
| test(import.meta.url, ({ runBundler, readOutputFiles }) => { | ||
| runBundler({ SENTRY_TEST_RECORD_UPLOADED_SOURCES: "1" }); | ||
| const files = readOutputFiles(); | ||
|
|
||
| expect(Object.keys(files).sort()).toMatchInlineSnapshot(` | ||
| [ | ||
| "common.js", | ||
| "common.js.map", | ||
| "entry1.js", | ||
| "entry1.js.map", | ||
| "entry2.js", | ||
| "entry2.js.map", | ||
| "sentry-cli-mock.json", | ||
| "sentry-uploaded-sources.json", | ||
| ] | ||
| `); | ||
| expect(JSON.parse(files["sentry-uploaded-sources.json"]!)).toMatchInlineSnapshot(` | ||
| [ | ||
| [ | ||
| "../../src/entry1.js", | ||
| ], | ||
| ] | ||
| `); | ||
| expect(files["sentry-cli-mock.json"]).toMatchInlineSnapshot(` | ||
| "["release","create","CURRENT_SHA","--project","fake-project"], | ||
| ["release","set-commits","CURRENT_SHA","--auto"], | ||
| ["release","finalize","CURRENT_SHA"], | ||
| ["sourcemap","upload","-p","fake-project","--release","CURRENT_SHA","sentry-bundler-plugin-upload-path"], | ||
| " | ||
| `); | ||
| }); |
13 changes: 13 additions & 0 deletions
13
dev-packages/bundler-plugin-integration-tests/fixtures/rollup4/sourcemaps-ignore.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import { sentryRollupPlugin } from "@sentry/bundler-plugins/rollup"; | ||
| import { defineConfig } from "rollup"; | ||
| import { sentryConfig } from "../configs/sourcemaps-ignore.config.js"; | ||
|
|
||
| export default defineConfig({ | ||
| input: ["src/entry1.js", "src/entry2.js"], | ||
| output: { | ||
| dir: "out/sourcemaps-ignore", | ||
| chunkFileNames: "[name].js", | ||
| sourcemap: true, | ||
| }, | ||
| plugins: [sentryRollupPlugin(sentryConfig)], | ||
| }); | ||
37 changes: 37 additions & 0 deletions
37
dev-packages/bundler-plugin-integration-tests/fixtures/rollup4/sourcemaps-ignore.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import { expect } from "vitest"; | ||
| import { test } from "./utils"; | ||
|
|
||
| test(import.meta.url, ({ runBundler, readOutputFiles }) => { | ||
| runBundler({ SENTRY_TEST_RECORD_UPLOADED_SOURCES: "1" }); | ||
| const files = readOutputFiles(); | ||
|
|
||
| expect(Object.keys(files).sort()).toMatchInlineSnapshot(` | ||
| [ | ||
| "common.js", | ||
| "common.js.map", | ||
| "entry1.js", | ||
| "entry1.js.map", | ||
| "entry2.js", | ||
| "entry2.js.map", | ||
| "sentry-cli-mock.json", | ||
| "sentry-uploaded-sources.json", | ||
| ] | ||
| `); | ||
| expect(JSON.parse(files["sentry-uploaded-sources.json"]!)).toMatchInlineSnapshot(` | ||
| [ | ||
| [ | ||
| "../../src/common.js", | ||
| ], | ||
| [ | ||
| "../../src/entry1.js", | ||
| ], | ||
| ] | ||
| `); | ||
| expect(files["sentry-cli-mock.json"]).toMatchInlineSnapshot(` | ||
| "["release","create","CURRENT_SHA","--project","fake-project"], | ||
| ["release","set-commits","CURRENT_SHA","--auto"], | ||
| ["release","finalize","CURRENT_SHA"], | ||
| ["sourcemap","upload","-p","fake-project","--release","CURRENT_SHA","sentry-bundler-plugin-upload-path"], | ||
| " | ||
| `); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
dev-packages/bundler-plugin-integration-tests/fixtures/vite8/sourcemaps-assets.config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { sentryVitePlugin } from "@sentry/bundler-plugins/vite"; | ||
| import { defineConfig } from "vite"; | ||
| import { sentryConfig } from "../configs/sourcemaps-assets.config.js"; | ||
|
|
||
| export default defineConfig({ | ||
| build: { | ||
| minify: false, | ||
| sourcemap: true, | ||
| rollupOptions: { | ||
| input: ["src/entry1.js", "src/entry2.js"], | ||
| output: { | ||
| dir: "out/sourcemaps-assets", | ||
| chunkFileNames: "[name].js", | ||
| entryFileNames: "[name].js", | ||
| }, | ||
| }, | ||
| }, | ||
| plugins: [sentryVitePlugin(sentryConfig)], | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to raise that the fixtures never take the staged upload path, but I think that's covered by your stack? If this PR is meant only as a baseline before the stack, then we should maybe say that in the description, and make sure each stack PR adds the staged variant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The staged upload path will be covered in the stack but I haven't got that far yet. I've added a ref. to this in the description.
I think eventually It would be good to move Roll{up,down}, Vite and webpack to only use the staged path, but that's a behavioural change because we would stop picking up maps that weren't in the build. I would say that's desirable, but it is a change. It looks like esbuild, Turbopack, SvelteKit and Nuxt will not be able to go this route though 🤔