Skip to content

fix(windows): Bound PE debug directory parsing - #2062

Open
jpnurmi wants to merge 4 commits into
masterfrom
jpnurmi/fix/pdb-directory-bounds
Open

fix(windows): Bound PE debug directory parsing#2062
jpnurmi wants to merge 4 commits into
masterfrom
jpnurmi/fix/pdb-directory-bounds

Conversation

@jpnurmi

@jpnurmi jpnurmi commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Keep PE debug records within the mapped image and require PDB filenames to terminate inside their CodeView record.

Close: NATIVE-222

Keep PE debug records within the mapped image and require PDB filenames to
terminate inside their CodeView record.

Close: NATIVE-222
@linear-code

linear-code Bot commented Sep 4, 2026

Copy link
Copy Markdown

NATIVE-222

Comment thread src/modulefinder/sentry_modulefinder_windows.c Outdated
Comment thread src/modulefinder/sentry_modulefinder_windows.c Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bc58c27. Configure here.

Comment thread src/modulefinder/sentry_modulefinder_windows.c Outdated
Comment thread src/modulefinder/sentry_modulefinder_windows.c
@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.71429% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.31%. Comparing base (7770d2e) to head (e5ed9e6).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2062   +/-   ##
=======================================
  Coverage   74.31%   74.31%           
=======================================
  Files         103      103           
  Lines       26661    26695   +34     
  Branches     4849     4861   +12     
=======================================
+ Hits        19813    19839   +26     
+ Misses       5519     5515    -4     
- Partials     1329     1341   +12     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants