Repository navigation
feat(linux): Support optional stack capture size limit - #2137
Merged
jpnurmi merged 9 commits intoOct 5, 2026
Merged
Conversation
cerisier
marked this pull request as ready for review
September 25, 2026 17:30
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2137 +/- ##
==========================================
- Coverage 75.41% 75.37% -0.04%
==========================================
Files 103 103
Lines 28105 28119 +14
Branches 5132 5136 +4
==========================================
Hits 21194 21194
- Misses 5578 5585 +7
- Partials 1333 1340 +7 🚀 New features to boost your workflow:
|
Collaborator
|
Presumably, the native backend has the same problem. Since we plan to make it the default backend in 1.x, let's fix it too while we're at it, and drop the |
Collaborator
|
Sorry about the bogus NDK lint failure - fixed by #2139 |
jpnurmi
changed the title
The x86_64 red zone puts the capture start 128 bytes below SP. When the capture limit fits entirely below SP, omit the red zone so the captured range includes SP. Use an explicit nonzero limit for non-crashing threads in place of the internal 1 MiB default. Keep the default when the option is zero and for the crashing thread.
jpnurmi
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up getsentry/crashpad#165 for Zig programs, which place a 256 KiB alternate signal stack in static TLS for every thread.
Related
crashpadPR: getsentry/crashpad#172