Repository navigation
docs: Refresh docs against current code - #201
Merged
Merged
Conversation
Co-Authored-By: Joshua Li <14209781+joshuarli@users.noreply.github.com>
Co-Authored-By: Joshua Li <14209781+joshuarli@users.noreply.github.com>
kenzoengineer
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs refresh for the whole repo, no audience filter. Only docs changed. No source files were touched.
Corrected against code
docs/setup.mdtold you to set"path": "sentry-options/"inrepos.json.copy_schemas(clients/rust/src/schema_fetch.rs) expects{namespace}/schema.jsondirectly under that path, so the value as written copies no schemas. Every entry in the automator's realrepos.jsonusessentry-options/schemas.docs/setup.mdpinnedsentry-options1.1.1 and the workflow and hook to SHA0b115be, which is 82 commits behindmainand older than 1.2.0. The same page tells you to useOptions::builder(), which shipped in 1.2.0 and 1.2.1 (CHANGELOG.md). The pins now use 1.2.17, the current release on crates.io and PyPI, and the1.2.17tag commit.docs/setup.md, Rust section: manual refresh pointed atsentry_options.refresh, which is the Python name. In Rust,refresh()is only a method on anOptionsinstance (clients/rust/src/lib.rs). The global store from.init()does not expose it.docs/architecture.mdnow documents.build()and this limitation.docs/options.md: the Rust test snippets called.get()on theResultthatoptions("seer")returns, which does not compile. I fixed them and compiled them against the crate.docs/options.md, deleting a feature flag: the definition step only covered sentry'smanager.add. It now names theschema.jsonentry for other services. The fallback behavior is now split by layer: the client returnsFalsefor a flag with no value (FeatureChecker::try_has).examples/README.md:sentry-options-test, butkubectl logstargetedsentry-options-example.string-option, whichexamples/python/main.pyprints.Restructured
AGENTS.mdnow has the build, lint, and test commands from.github/workflows/main.ymlandpyproject.toml. It also lists the invariants (maturin-only Python build, schema evolution rules, craft-generated changelog) and links both example READMEs.README.md: cut filler, linked the setup guide from the quickstart, and added where to get help and the license.docs/options.md: added the missing "Diffing effective values" entry to the table of contents.Could not verify
docs/options.md, deleting an option).Code looks wrong, not the doc
refresh(). As a result,Options::builder().with_refresh_threshold(None).init()freezes values for the life of the process. Python hassentry_options.refresh()for the same mode.sentry_options/__init__.pymodule docstring says the library "watches for file changes". It actually refreshes on read. I reported this instead of editing it, because this pass does not change source.tests/gen_stubs_test.py. It passes locally.Cargo.toml, the[workspace.dependencies]sentry-optionsversion is still1.2.11.scripts/bump-version.shdoes not update it.Not covered
CHANGELOG.mdis a dated record that craft generates, so I left it alone..claude/skillsdefer to the docs. I checked them and they did not need changes.via @joshuarli.
--
View Junior Session [Sentry]