Skip to content

feat(integrations): Add http.route attribute to server spans - #7183

Open
mjq wants to merge 1 commit into
masterfrom
mjq/http-route-server-spans
Open

feat(integrations): Add http.route attribute to server spans#7183
mjq wants to merge 1 commit into
masterfrom
mjq/http-route-server-spans

Conversation

@mjq

@mjq mjq commented Aug 12, 2026

Copy link
Copy Markdown
Member

Description

Currently the HTTP path template is only available in the span name. Make it available as a semantic attribute as well (http.route - definition in conventions).

This will also let us use this in e.g. HTTP server span description generation, which will be necessary to maintain consistent descriptions between transactions and span streaming.

Issues

@linear-code

linear-code Bot commented Aug 12, 2026

Copy link
Copy Markdown

PY-2732

cursor[bot]
cursor Bot reviewed Aug 12, 2026
View reviewed changes
Comment thread sentry_sdk/scope.py Outdated
@github-actions

github-actions Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 121590 passed | ⏭️ 6762 skipped | Total: 128352 | Pass Rate: 94.73% | Execution Time: 429m 51s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +20
Passed Tests 📈 +20
Failed Tests —
Skipped Tests —

All tests are passing successfully.

✅ Patch coverage is 98.18%. Project has 2486 uncovered lines.
✅ Project coverage is 90.34%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/asgi.py 80.00% ⚠️ 1 Missing and 1 partials
Coverage diff 
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.30%    90.34%    +0.04%
==========================================
  Files          193       193         —
  Lines        25689     25734       +45
  Branches      9480      9504       +24
==========================================
+ Hits         23198     23248       +50
- Misses        2491      2486        -5
- Partials      1442      1445        +3

Generated by Codecov Action

sentry-warden[bot]
sentry-warden Bot reviewed Aug 12, 2026
View reviewed changes
Comment thread sentry_sdk/integrations/asgi.py
@mjq
mjq force-pushed the mjq/http-route-server-spans branch from dddf367 to b1363a5 Compare August 13, 2026 20:16
cursor[bot]
cursor Bot reviewed Aug 13, 2026
View reviewed changes
Comment thread sentry_sdk/integrations/starlette.py
@mjq mjq mentioned this pull request Aug 13, 2026
Merged
mjq added a commit that referenced this pull request Aug 24, 2026
@mjq
fix(starlette): Set transaction name on current scope in sync handler (…
9147b3c 
…#7201)

The sync request/response handler passed the _isolation_ scope to
`_set_transaction_name_and_source`, but the transaction/segment span
lives on the _current_ scope. As a result the route-resolved name never
reached the span for sync endpoints, which were instead named by the raw
URL from the ASGI middleware (`transaction_info.source` of `url` rather
than `route`). Async handlers already used the current scope and were
unaffected.

Pass the current scope (already computed above) so sync and async
handlers behave identically:
- streaming: the segment name / `sentry.segment.name.source` are
route-based
- static: the transaction event name / source are route-based

For parametrized routes this also removes high-cardinality URL
transaction names for sync endpoints.

Found while working on
#7183.
sentrivana pushed a commit that referenced this pull request Aug 25, 2026
@mjq @sentrivana
fix(starlette): Set transaction name on current scope in sync handler (…
9af3060 
…#7201)

The sync request/response handler passed the _isolation_ scope to
`_set_transaction_name_and_source`, but the transaction/segment span
lives on the _current_ scope. As a result the route-resolved name never
reached the span for sync endpoints, which were instead named by the raw
URL from the ASGI middleware (`transaction_info.source` of `url` rather
than `route`). Async handlers already used the current scope and were
unaffected.

Pass the current scope (already computed above) so sync and async
handlers behave identically:
- streaming: the segment name / `sentry.segment.name.source` are
route-based
- static: the transaction event name / source are route-based

For parametrized routes this also removes high-cardinality URL
transaction names for sync endpoints.

Found while working on
#7183.
@mjq
mjq force-pushed the mjq/http-route-server-spans branch from b1363a5 to 1d15a6d Compare August 26, 2026 20:10
@mjq mjq changed the title fix(spans): Add http.route attribute to HTTP server spans feat(integrations): Add http.route attribute to server spans Aug 26, 2026
cursor[bot]
cursor Bot reviewed Aug 26, 2026
View reviewed changes
Comment thread sentry_sdk/integrations/starlette.py
@mjq mjq mentioned this pull request Aug 26, 2026
Merged
mjq
mjq commented Aug 27, 2026
View reviewed changes
Comment thread sentry_sdk/scope.py
for attribute, value in attributes.items():
self.set_attribute(attribute, value)

def set_segment_attribute(self, key: str, value: "AttributeValue") -> None:

@mjq mjq Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed like a useful helper function to have (and avoids duplicating this code in every HTTP integration), but I would also understand if we don't want to expand the API surface with this: it makes the "segment" name a public thing which AIUI we are trying to avoid? I'm not sure the best path forward here.

Comment thread sentry_sdk/integrations/starlette.py
sentrivana pushed a commit that referenced this pull request Aug 27, 2026
@mjq
fix(starlette): Use url transaction source for host routing (#7266)
8fae8a6 
### Description

When host routing, we don't have a route and instead fall back to the
request path for the transaction name. This should be given transaction
source `url` (for raw URLs) instead of the current value of `route` (for
parameterized routes).

This matters for #7183, where the mis-categorized transaction source
would lead to bad data in `http.route`. (Bug found by Cursor in
#7183 (comment)
when reviewing that PR).
@mjq
mjq marked this pull request as ready for review August 27, 2026 18:42
@mjq
mjq requested a review from a team as a code owner August 27, 2026 18:42
cursor[bot]
cursor Bot reviewed Aug 27, 2026
View reviewed changes
Comment thread sentry_sdk/integrations/aiohttp.py Outdated
@mjq
mjq marked this pull request as draft August 28, 2026 19:24
@mjq
mjq force-pushed the mjq/http-route-server-spans branch from fdd83b4 to 2b3c0c5 Compare August 31, 2026 14:52
@mjq
mjq force-pushed the mjq/http-route-server-spans branch from 2b3c0c5 to 20d2496 Compare August 31, 2026 14:55
cursor[bot]
cursor Bot reviewed Aug 31, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 20d2496. Configure here.

@mjq
mjq marked this pull request as ready for review August 31, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments
@sentry-warden sentry-warden[bot] sentry-warden[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

http.route missing from HTTP server spans

1 participant

@mjq