chore(django): Remove transaction-based tracing - #7190
Merged
Conversation
Contributor
Codecov Results 📊✅ 109277 passed | ⏭️ 5310 skipped | Total: 114587 | Pass Rate: 95.37% | Execution Time: 361m 39s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 92.59%. Project has 2235 uncovered lines. Files with missing lines (6)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.23% 90.56% +0.33%
==========================================
Files 193 185 -8
Lines 25482 23688 -1794
Branches 9384 8712 -672
==========================================
+ Hits 22994 21453 -1541
- Misses 2488 2235 -253
- Partials 1431 1359 -72Generated by Codecov Action |
sentrivana
force-pushed
the
ivana/major/remove-transactions-django
branch
from
August 27, 2026 12:21
d18f306 to
f561028
Compare
sentrivana
commented
Aug 28, 2026
Comment on lines
+852
to
+856
| # TODO: remove this once record_sql_queries drops support for old spans | ||
| from sentry_sdk.traces import StreamedSpan | ||
|
|
||
| if not isinstance(span, StreamedSpan): | ||
| return |
Contributor
Author
There was a problem hiding this comment.
The hack mentioned in the description ^
sentrivana
marked this pull request as ready for review
August 28, 2026 09:33
ericapisani
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes a small hack to make the tests pass until
record_sql_queriesdrops transaction support in a later PR: https://github.com/getsentry/sentry-python/pull/7190/changes#r3879480876Closes PY-2689
Closes #7085