Skip to content

fix(openai_agents): correctly patch turn_preparation.get_model to capture model spans #7227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
x-tahosin wants to merge 2 commits into from
Closed

fix(openai_agents): correctly patch turn_preparation.get_model to capture model spans #7227

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
078a60c
fix(openai_agents): patch get_all_tools to capture function calls acc…
Aug 23, 2026
ecb315d
fix(openai_agents): correctly patch turn_preparation.get_model instea…
Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions sentry_sdk/integrations/openai_agents/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,18 @@ def new_wrapped_get_model(

agents.run_internal.run_loop.get_model = new_wrapped_get_model

if not use_run_hooks and hasattr(run_loop, "get_all_tools"):

@cursor cursor Bot Aug 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreachable get_all_tools patch

High Severity

The new get_all_tools wrap is gated on not use_run_hooks, but this block only runs for openai-agents >= 0.8, where use_run_hooks is always true. The condition can never succeed, so the patch never installs and the PR's intended tool-call spans stay missing.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 3508792. Configure here.

original_get_all_tools = run_loop.get_all_tools
@wraps(original_get_all_tools)
async def new_wrapped_get_all_tools(
agent: "agents.Agent", context_wrapper: "agents.RunContextWrapper"
) -> "list[agents.Tool]":
return await _get_all_tools(
original_get_all_tools, agent, context_wrapper
)
agents.run_internal.run_loop.get_all_tools = new_wrapped_get_all_tools
Comment thread
cursor[bot] marked this conversation as resolved.


if turn_resolution is not None:
original_execute_handoffs = turn_resolution.execute_handoffs

Expand Down