test: Access the 'type' in an event using .get - #7239
Merged
Conversation
`select_transactions_with_mcp_spans` assumes that all events provided to the helper are transactions and contain a `type` key. However, not all events contain 'type's and so passing events that may contain a log would raise a KeyError.
alexander-alderman-webb
approved these changes
Aug 24, 2026
ericapisani
enabled auto-merge (squash)
August 24, 2026 12:47
Contributor
Codecov Results 📊✅ 113725 passed | ⏭️ 6732 skipped | Total: 120457 | Pass Rate: 94.41% | Execution Time: 404m 54s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2488 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.22% 90.22% —%
==========================================
Files 193 193 —
Lines 25433 25433 —
Branches 9346 9346 —
==========================================
+ Hits 22945 22945 —
- Misses 2488 2488 —
- Partials 1437 1437 —Generated by Codecov Action |
sentrivana
pushed a commit
that referenced
this pull request
Aug 25, 2026
`select_transactions_with_mcp_spans` assumes that all events provided to the helper are transactions and contain a `type` key. However, not all events contain 'type's and so passing events that may contain a log would raise a KeyError. Relates to #7224
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
select_transactions_with_mcp_spansassumes that all events provided to the helper are transactions and contain atypekey.However, not all events contain 'type's and so passing events that may contain a log would raise a KeyError.
Relates to #7224