fix(starlette): Gate request body collection on data_collection experiment - #7253
Merged
ericapisani merged 1 commit intoAug 26, 2026
Merged
Conversation
…iment Only attach request body data to events and spans when "incoming_request" is present in the data_collection.http_bodies experiment option (or when the experiment is unset, preserving default behavior). Refs PY-2419 Refs #6283
Contributor
Codecov Results 📊✅ 117998 passed | ⏭️ 6732 skipped | Total: 124730 | Pass Rate: 94.6% | Execution Time: 418m 1s 📊 Comparison with Base Branch
➖ Removed Tests (2)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2486 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.22% 90.24% +0.02%
==========================================
Files 193 193 —
Lines 25435 25459 +24
Branches 9346 9366 +20
==========================================
+ Hits 22947 22973 +26
- Misses 2488 2486 -2
- Partials 1434 1433 -1Generated by Codecov Action |
sentrivana
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only attach request body data to events and spans when "incoming_request" is present in the data_collection.http_bodies experiment option (or when the experiment is unset, preserving default behavior).
Refs PY-2419
Refs #6283