fix(integrations): Gate REMOTE_ADDR on data_collection.user_info - #7298
Merged
Conversation
REMOTE_ADDR was previously set unconditionally in the request env for aiohttp, sanic, and tornado. Now it respects the data_collection.user_info experiment when data collection is enabled, falling back to the legacy unconditional behaviour otherwise. Fixes PY-2751 Fixes #7297
Contributor
Codecov Results 📊✅ 2172 passed | ⏭️ 239 skipped | Total: 2411 | Pass Rate: 90.09% | Execution Time: 3m 49s 📊 Comparison with Base Branch
All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 16093 uncovered lines. Files with missing lines (3)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 90.30% 37.15% -53.15%
==========================================
Files 193 193 —
Lines 25601 25604 +3
Branches 9436 9442 +6
==========================================
+ Hits 23116 9511 -13605
- Misses 2485 16093 +13608
- Partials 1435 516 -919Generated by Codecov Action |
sentrivana
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REMOTE_ADDR was previously set unconditionally in the request env for aiohttp, sanic, and tornado. Now it respects the data_collection.user_info experiment when data collection is enabled, falling back to the legacy unconditional behaviour otherwise.
Fixes PY-2751
Fixes #7297