Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion sentry_sdk/integrations/aiohttp.py
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,21 @@ def aiohttp_processor(
request.path,
)

request_info["query_string"] = request.query_string
if has_data_collection_enabled(client_options):
if request.query_string:
filtered_query_string = (
_apply_data_collection_filtering_to_query_string(
query_string=request.query_string,
behaviour=client_options["data_collection"][
"url_query_params"
],
)
)
if filtered_query_string:
request_info["query_string"] = filtered_query_string
else:
request_info["query_string"] = request.query_string

request_info["method"] = request.method

# REMOTE_ADDR was unconditionally set pre-data collection, so it
Expand Down
38 changes: 38 additions & 0 deletions tests/integrations/aiohttp/test_aiohttp.py
Original file line number Diff line number Diff line change
Expand Up @@ -2273,6 +2273,44 @@ async def hello(request):
assert inner_client_span["attributes"]["url.query"] == expected_query


@pytest.mark.asyncio
@pytest.mark.parametrize(
"init_kwargs, expected_query", _QUERY_PARAM_DATA_COLLECTION_CASES
)
async def test_server_url_query_data_collection_event_processor(
sentry_init, aiohttp_client, capture_events, init_kwargs, expected_query
):
init_kwargs = dict(init_kwargs)
sentry_init(integrations=[AioHttpIntegration()], **init_kwargs)

async def hello(request):
1 / 0

app = web.Application()
app.router.add_get("/", hello)

events = capture_events()

client = await aiohttp_client(app)
resp = await client.get("/?toy=tennisball&color=red&auth=secret")
assert resp.status == 500

(event,) = events

host = event["request"]["headers"]["Host"]
assert event["request"]["url"] == "http://{host}/".format(host=host)
assert event["request"]["method"] == "GET"

if "data_collection" not in init_kwargs.get("_experiments", {}):
assert (
event["request"]["query_string"] == "toy=tennisball&color=red&auth=secret"
)
elif expected_query is None:
assert "query_string" not in event["request"]
else:
assert event["request"]["query_string"] == expected_query


@pytest.mark.asyncio
@pytest.mark.parametrize(
"init_kwargs, expect_remote_addr", DATA_COLLECTION_REMOTE_ADDR_CASES
Expand Down
Loading