Skip to content

chore(litestar): Remove transaction-based tracing - #7310

Merged
alexander-alderman-webb merged 2 commits into
major/3.0from
webb/litestar/remove-transactions
Aug 31, 2026
Merged

chore(litestar): Remove transaction-based tracing#7310
alexander-alderman-webb merged 2 commits into
major/3.0from
webb/litestar/remove-transactions

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Description

I've removed

  • test_request_body_data_collection()
  • test_request_body_data_collection_wins_over_send_default_pii()
  • test_cookie_data_collection()

since LiteStar doesn't capture cookies or request bodies on streamed spans.

Issues

Closes #7099

Reminders

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

108697 passed | ⏭️ 5338 skipped | Total: 114035 | Pass Rate: 95.32% | Execution Time: 366m 0s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -11787
Passed Tests 📉 -10363
Failed Tests
Skipped Tests 📉 -1424

All tests are passing successfully.

✅ Patch coverage is 81.48%. Project has 2266 uncovered lines.
✅ Project coverage is 90.46%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/litestar.py 81.48% ⚠️ 5 Missing and 5 partials
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.29%    90.46%    +0.17%
==========================================
  Files          193       185        -8
  Lines        25601     23760     -1841
  Branches      9436      8752      -684
==========================================
+ Hits         23116     21494     -1622
- Misses        2485      2266      -219
- Partials      1435      1368       -67

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review August 31, 2026 08:35
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner August 31, 2026 08:35
@alexander-alderman-webb
alexander-alderman-webb merged commit 77a04be into major/3.0 Aug 31, 2026
129 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/litestar/remove-transactions branch August 31, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants