chore(fastapi): Drop transactions - #7337
Merged
Merged
Conversation
sentrivana
marked this pull request as ready for review
September 2, 2026 12:20
Contributor
Codecov Results 📊✅ 117314 passed | ⏭️ 5560 skipped | Total: 122874 | Pass Rate: 95.48% | Execution Time: 393m 21s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2256 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.23% 90.45% +0.22%
==========================================
Files 193 185 -8
Lines 25667 23628 -2039
Branches 9462 8674 -788
==========================================
+ Hits 23160 21372 -1788
- Misses 2507 2256 -251
- Partials 1444 1369 -75Generated by Codecov Action |
alexander-alderman-webb
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Also converted tests that were assuming
trace_lifecycle="static", and dropped transaction-specific tests that are not transferable to span streaming.Issues
Closes https://linear.app/getsentry/issue/PY-2692/remove-transaction-based-tracing-from-fastapi
Reminders
uv run ruff.feat:,fix:,ref:,meta:)