Skip to content

feat(aiohttp): Add http.route attribute - #7341

Open
alexander-alderman-webb wants to merge 2 commits into
masterfrom
webb/aiothttp/http-route
Open

feat(aiohttp): Add http.route attribute#7341
alexander-alderman-webb wants to merge 2 commits into
masterfrom
webb/aiothttp/http-route

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Contributor

Description

Set the http.route attribute on the server span in patches for aiohttp endpoints.

Issues

Reminders

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review September 2, 2026 13:18
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner September 2, 2026 13:18

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 62c6bb6. Configure here.

Comment thread sentry_sdk/integrations/aiohttp.py
Comment thread sentry_sdk/integrations/aiohttp.py
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

130414 passed | ❌ 1 failed | ⏭️ 7110 skipped | Total: 137525 | Pass Rate: 94.83% | Execution Time: 458m 1s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +11
Passed Tests 📈 +12
Failed Tests 📉 -1
Skipped Tests

➖ Removed Tests (1)

View removed tests
  • test_continuous_profiler_auto_start_and_stop_sampled[non-experiment-gevent]
    • File: tests.profiler.test_continuous_profiler

❌ Failed Tests

test_continuous_profiler_auto_start_and_stop_sampled[experiment-thread]

File: tests.profiler.test_continuous_profiler
Suite: py3.14t-common
Error: AssertionError: profiler should not be running assert '21ba5b2933e44027a3d272c7a22b29a9' is None + where '21ba5b2933e44027a3d272c7a22b29a9' = get_profiler_id()

Stack Trace
tests/profiler/test_continuous_profiler.py:812: in test_continuous_profiler_auto_start_and_stop_sampled
    assert get_profiler_id() is None, "profiler should not be running"
E   AssertionError: profiler should not be running
E   assert '21ba5b2933e44027a3d272c7a22b29a9' is None
E    +  where '21ba5b2933e44027a3d272c7a22b29a9' = get_profiler_id()

✅ Patch coverage is 100.00%. Project has 2507 uncovered lines.
❌ Project coverage is 90.24%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    90.25%    90.24%    -0.01%
==========================================
  Files          193       193         —
  Lines        25677     25681        +4
  Branches      9466      9468        +2
==========================================
+ Hits         23172     23174        +2
- Misses        2505      2507        +2
- Partials      1441      1443        +2

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants