Skip to content

feat(bottle): Add http.route attribute #7343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexander-alderman-webb wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(bottle): Add http.route attribute #7343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb2c9dd
feat(bottle): Add http.route attribute
alexander-alderman-webb Sep 2, 2026
f91004f
catch RuntimeError
alexander-alderman-webb Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions sentry_sdk/integrations/bottle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from typing import TYPE_CHECKING

import sentry_sdk
from sentry_sdk.consts import SPANDATA
Comment thread
alexander-alderman-webb marked this conversation as resolved.
from sentry_sdk.integrations import (
_DEFAULT_FAILED_REQUEST_STATUS_CODES,
DidNotEnable,
Expand Down Expand Up @@ -104,6 +105,17 @@ def _patched_handle(self: "Bottle", environ: "Dict[str, Any]") -> "Any":
)
res = old_handle(self, environ)

server_span = sentry_sdk.get_current_scope()._server_segment_span
if server_span is not None:
route_path = None
try:
route_path = bottle_request.route.rule
except RuntimeError:
pass

if route_path is not None:
server_span.set_attribute(SPANDATA.HTTP_ROUTE, route_path)

if has_span_streaming_enabled(sentry_sdk.get_client().options):
_set_segment_name_and_source(
transaction_style=integration.transaction_style
Expand Down
27 changes: 27 additions & 0 deletions tests/integrations/bottle/test_bottle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

import sentry_sdk
from sentry_sdk import capture_message
from sentry_sdk.consts import SPANDATA
from sentry_sdk.integrations.bottle import BottleIntegration
from sentry_sdk.integrations.logging import LoggingIntegration
from sentry_sdk.serializer import MAX_DATABAG_BREADTH
Expand Down Expand Up @@ -662,6 +663,32 @@ def named_hi():
assert segment["attributes"]["sentry.segment.name.source"] == expected_source


def test_http_route(
sentry_init,
capture_items,
):
sentry_init(
integrations=[BottleIntegration()],
traces_sample_rate=1.0,
trace_lifecycle="stream",
)
items = capture_items("span")

app = Bottle()

@app.route("/message/<message_id>")
def hi_with_id(message_id):
return "ok"

client = Client(app)
client.get("/message/123456")

sentry_sdk.flush()

(segment,) = (item.payload for item in items if item.payload.get("is_segment"))
assert segment["attributes"][SPANDATA.HTTP_ROUTE] == "/message/<message_id>"


def test_span_streaming_with_error(sentry_init, capture_items):
sentry_init(
integrations=[BottleIntegration()],
Expand Down
Loading