Repository navigation
Conversation
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
6 of 9 tasks
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
| [SentrySDKWrapper configureScope:^(SentryScope *_Nonnull scope) { | ||
| // Serialize to get contexts dictionary | ||
| NSDictionary *serializedScope = [scope serialize]; | ||
| NSDictionary *serializedScope = [RNSentryInternalWrapper serializeScope:scope]; |
Contributor
There was a problem hiding this comment.
Pinned Cocoa version lacks the new internal serializer APIs
Update the bundled sentry-cocoa version before building this change. The Swift bridge calls internal scope and debug-meta serializer APIs that are not available in the pinned 9.30.2 dependency, so native builds will fail until the dependency provides them.
Evidence
RNSentry.mmcallsRNSentryInternalWrapper.serializeScope; the wrapper forwards toRNSentryInternal.serializeScope, which callsSentrySDK.internal.serializer.serialize(scope:).RNSentry+fetchNativeStack.malso calls the new debug-meta serializer throughRNSentryInternal.serializeDebugMeta.RNSentry.podspecandPackage.swiftboth pin sentry-cocoa to9.30.2.- The PR context says these serializer APIs require a Cocoa release that has not yet been added to the bundled dependency, leaving the Swift bridge without the APIs it references at build time.
Also found at 1 additional location
packages/core/ios/Swift/RNSentryInternal.swift:100-106
Identified by Warden · code-review · ESP-4NA
philprime
marked this pull request as ready for review
October 20, 2026 14:03
philprime
requested review from
alwx,
antonis and
lucas-zimerman
as code owners
October 20, 2026 14:03
📲 Install BuildsAndroid
|
Contributor
|
@philprime seems like the |
| // MARK: - Serialization | ||
|
|
||
| @_spi(Private) @objc public static func serializeScope(_ scope: Scope) -> [String: Any] { | ||
| SentrySDK.internal.serializer.serialize(scope: scope) |
Collaborator
There was a problem hiding this comment.
Could you check the failure errors that are showing here ? https://github.com/getsentry/sentry-react-native/pull/6917/changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Route native scope and debug-image serialization through Cocoa's internal serializer instead of public model
serialize()methods. Preserve the dictionaries returned to JavaScript.💡 Motivation and Context
Prepares for Cocoa's v10-only serialization API removal, while allowing migration on v9.
Dependency: Requires a Cocoa release containing the new internal scope and debug-image serializer APIs. The bundled Cocoa version has not been bumped to an unreleased version, so native CI may fail until that dependency is available.
💚 How did you test it?
Local
yarn build,yarn test,yarn lint, andyarn circularDepCheckpassed. Native integration validation is delegated to CI.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Release the Cocoa replacement APIs, update the native dependency through the established workflow, and confirm native CI before merging.