Skip to content

docs: Require issue discussion before PRs - #6919

Merged
antonis merged 5 commits into
mainfrom
docs/require-issue-discussion
Oct 22, 2026
Merged

antonis merged 5 commits into
mainfrom
docs/require-issue-discussion

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Enhancement

📜 Description

Asks external contributors to discuss a change with a maintainer in a GitHub issue before opening a PR. PRs without that prior discussion may be closed.

Changes to CONTRIBUTING.md:

  • Adds the centered Sentry logo header and a short welcome with a Discord link (discord.com/invite/sentry).
  • Adds a Submitting Changes section with:
    • a TL;DR: discuss in an issue first; PRs without prior discussion may be closed
    • Before You Start: find or create an issue, agree on the approach with a maintainer, check the assignee
    • Making Your Contribution: tests are required for non-trivial PRs, don't bump version numbers, open a draft PR that links the issue, follow the commit message format, keep PRs focused
    • AI Use, moved up from the end of the file. It now also says contributors must understand the changes they propose, not just review and test them.

💡 Motivation and Context

Aligns with getsentry/sentry-cocoa#9396 and getsentry/sentry-java#6288 so the mobile SDKs share the same contribution policy, with only the repo name changed. The wording says we may close PRs rather than promising automatic closing, because the validate-pr workflow only posts an advisory comment.

💚 How did you test it?

Docs-only change; reviewed the Markdown structure.

#skip-changelog

via Chris Aigner.

--

View Junior Session [Sentry]

Co-Authored-By: Chris Aigner <christoph.aigner@sentry.io>
@github-actions

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor
Fails
🚫 Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request

Generated by 🚫 dangerJS against 2c86aae

sentry-junior Bot and others added 3 commits October 20, 2026 16:17
Co-Authored-By: Chris Aigner <christoph.aigner@sentry.io>
Co-Authored-By: Chris Aigner <christoph.aigner@sentry.io>
@christophaigner
christophaigner marked this pull request as ready for review October 22, 2026 08:49

@antonis antonis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added a small suggestion regarding the logo visibility in dark mode

Comment thread CONTRIBUTING.md
@antonis
antonis merged commit 8547b02 into main Oct 22, 2026
58 of 64 checks passed
@antonis
antonis deleted the docs/require-issue-discussion branch October 22, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants