chore(client-reports): Prevent client report loss when envelope dropped#1195
Merged
Conversation
Prevent client report data from being lost when an envelope containing a client report is dropped by adding all losses from the lost client report back into the aggregator. This ensures that the next outgoing envelope will include the loss data. This change fixes some undesirable behavior I discovered while manually testing client reports: if the transport queue overflows when sending an error, we record a lost error event. If we then immediately try to send another error, that envelope will pick up the loss, draining it from the aggregator, but if the queue is still full, that envelope will also get lost with the client report. We will record the lost error event from the second envelope, but without this change, we would not include the loss from the first envelope. If we consider the case where many envelopes get sent in rapid succession and overflow the queue, we could end up with a severe undercount of reported losses as a result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent client report data from being lost when an envelope containing a client report is dropped by adding all losses from the lost client report back into the aggregator. This ensures that the next outgoing envelope will include the loss data.
This change fixes some undesirable behavior I discovered while manually testing client reports: if the transport queue overflows when sending an error, we record a lost error event. If we then immediately try to send another error, that envelope will pick up the loss, draining it from the aggregator, but if the queue is still full, that envelope will also get lost with the client report. We will record the lost error event from the second envelope, but without this change, we would not include the loss from the first envelope. If we consider the case where many envelopes get sent in rapid succession and overflow the queue, we could end up with a severe undercount of reported losses as a result.